[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2014-06-28 0:57:27
Message-ID: 20140628005727.18724.73594 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118970/
-----------------------------------------------------------
(Updated June 28, 2014, 12:57 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, KDE Frameworks, Aleix Pol Gonzalez, and Inge Wallin.
Repository: libkdeedu
Description
-------
Port tests away from KCmdLineArgs to QCommandLineParser.
Port from KDE_DEPRECATED to KEDUVOCDOCUMENT_DEPRECATED (Maybe we should remove \
these?) Port from KLocale to klocalizedstring.h
Diffs
-----
CMakeLists.txt 4feb10b67f78530170aaae216b9347cf94c0e51a
keduvocdocument/CMakeLists.txt c242c46fa79f128d63ccdeb5c4f611ad7294c874
keduvocdocument/keduvocarticle.h b0b69c06d3d91ecc1680ecb18c9dd074beed1cb1
keduvocdocument/keduvoccsvreader.cpp e3d471c4ecbb1236bae73714f27e357a1681ec70
keduvocdocument/keduvoccsvwriter.cpp 32172e47d3617c082378969735dbd23d3178f06e
keduvocdocument/keduvocdocument.h 9da14c62c84a07ffc53ef46f4c48e35824210d2c
keduvocdocument/keduvocdocument.cpp 7026ccb9046968821b11ce6e07276d81e58e41c6
keduvocdocument/keduvockvtml2reader.cpp 3884724422c318e34a5b8efc5e05481e27f7c6bc
keduvocdocument/keduvockvtmlcompability.cpp \
e486729054a9e69fd52c4e4f1031a0bdbb3433cf keduvocdocument/keduvocpaukerreader.cpp \
4ded3e480222ea9401b8cbfddad2b99ba82036fb keduvocdocument/keduvoctranslation.h \
c41d293755f0df7f87a41300569b093d020beb06 keduvocdocument/keduvocvokabelnreader.cpp \
ffbd64d3cd50e519af319d6d52a1491a7ed1588a keduvocdocument/keduvocwqlreader.cpp \
0841b1054ec41b93f4fffb1165c2c0d51806aeae keduvocdocument/keduvocxdxfreader.cpp \
4317f6ff1fbc8a4a19c2bbcc72af2ace295743b6 keduvocdocument/sharedkvtmlfiles.cpp \
9f74aa2af2f69f25fca8efa1585b8c8ea1127cd9 keduvocdocument/tests/CMakeLists.txt \
ac01a2b4a3e3b925517b2f004feb93bf365344a7 keduvocdocument/tests/converter.cpp \
1916b2269a88e932beb46f165e6cebebcefecb3c \
keduvocdocument/tests/sharedkvtmlfilestest.cpp \
489dad4fcafa0a97fe4e93905206fb0fc53e0cf5
Diff: https://git.reviewboard.kde.org/r/118970/diff/
Testing
-------
It still builds and the tests run.
Unrelated the sharedkvtmlfilestest exposes a bug in KEduVocDocument::open where the \
KFilterDev wont open, (bug from previous commit) not sure what to do here to fix it \
though.
Thanks,
Jeremy Whiting
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118970/">https://git.reviewboard.kde.org/r/118970/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, KDE Frameworks, Aleix Pol Gonzalez, and Inge \
Wallin.</div> <div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated June 28, 2014, 12:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdeedu
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port tests away from KCmdLineArgs to QCommandLineParser. Port from \
KDE_DEPRECATED to KEDUVOCDOCUMENT_DEPRECATED (Maybe we should remove these?) Port \
from KLocale to klocalizedstring.h</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It still builds and the tests run.
Unrelated the sharedkvtmlfilestest exposes a bug in KEduVocDocument::open where the \
KFilterDev wont open, (bug from previous commit) not sure what to do here to fix it \
though.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(4feb10b67f78530170aaae216b9347cf94c0e51a)</span></li>
<li>keduvocdocument/CMakeLists.txt <span style="color: \
grey">(c242c46fa79f128d63ccdeb5c4f611ad7294c874)</span></li>
<li>keduvocdocument/keduvocarticle.h <span style="color: \
grey">(b0b69c06d3d91ecc1680ecb18c9dd074beed1cb1)</span></li>
<li>keduvocdocument/keduvoccsvreader.cpp <span style="color: \
grey">(e3d471c4ecbb1236bae73714f27e357a1681ec70)</span></li>
<li>keduvocdocument/keduvoccsvwriter.cpp <span style="color: \
grey">(32172e47d3617c082378969735dbd23d3178f06e)</span></li>
<li>keduvocdocument/keduvocdocument.h <span style="color: \
grey">(9da14c62c84a07ffc53ef46f4c48e35824210d2c)</span></li>
<li>keduvocdocument/keduvocdocument.cpp <span style="color: \
grey">(7026ccb9046968821b11ce6e07276d81e58e41c6)</span></li>
<li>keduvocdocument/keduvockvtml2reader.cpp <span style="color: \
grey">(3884724422c318e34a5b8efc5e05481e27f7c6bc)</span></li>
<li>keduvocdocument/keduvockvtmlcompability.cpp <span style="color: \
grey">(e486729054a9e69fd52c4e4f1031a0bdbb3433cf)</span></li>
<li>keduvocdocument/keduvocpaukerreader.cpp <span style="color: \
grey">(4ded3e480222ea9401b8cbfddad2b99ba82036fb)</span></li>
<li>keduvocdocument/keduvoctranslation.h <span style="color: \
grey">(c41d293755f0df7f87a41300569b093d020beb06)</span></li>
<li>keduvocdocument/keduvocvokabelnreader.cpp <span style="color: \
grey">(ffbd64d3cd50e519af319d6d52a1491a7ed1588a)</span></li>
<li>keduvocdocument/keduvocwqlreader.cpp <span style="color: \
grey">(0841b1054ec41b93f4fffb1165c2c0d51806aeae)</span></li>
<li>keduvocdocument/keduvocxdxfreader.cpp <span style="color: \
grey">(4317f6ff1fbc8a4a19c2bbcc72af2ace295743b6)</span></li>
<li>keduvocdocument/sharedkvtmlfiles.cpp <span style="color: \
grey">(9f74aa2af2f69f25fca8efa1585b8c8ea1127cd9)</span></li>
<li>keduvocdocument/tests/CMakeLists.txt <span style="color: \
grey">(ac01a2b4a3e3b925517b2f004feb93bf365344a7)</span></li>
<li>keduvocdocument/tests/converter.cpp <span style="color: \
grey">(1916b2269a88e932beb46f165e6cebebcefecb3c)</span></li>
<li>keduvocdocument/tests/sharedkvtmlfilestest.cpp <span style="color: \
grey">(489dad4fcafa0a97fe4e93905206fb0fc53e0cf5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118970/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic