'Re: Review Request 118957: Fix search path in FindReadline.cmake'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 118957: Fix search path in FindReadline.cmake
From:       "Vadim Zhukov" <persgray () gmail ! com>
Date:       2014-06-26 21:57:38
Message-ID: 20140626215738.11642.621 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118957/
-----------------------------------------------------------

(Updated June 26, 2014, 9:57 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Repository: analitza

Description
-------

The "/usr/include/readline" path specification in FIND_PATH() call is extraneous:

1. "readline/" prefix is already present in the FIND_PATH() argument \
"readline/readline.h", so it should be cut off the path; 2. "/usr/include" is in \
standard search path for CMake.

This is probably a leftover from times when analitza tried to use "readline.h" \
instead of "readline/readline.h".

Diffs
-----

  cmake/FindReadline.cmake 8fc21ec 

Diff: https://git.reviewboard.kde.org/r/118957/diff/

Testing
-------

OpenBSD/i386-CURRENT

Thanks,

Vadim Zhukov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118957/">https://git.reviewboard.kde.org/r/118957/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Vadim Zhukov.</div>

<p style="color: grey;"><i>Updated June 26, 2014, 9:57 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
analitza
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The &quot;/usr/include/readline&quot; path specification in FIND_PATH() \
call is extraneous:

1. &quot;readline/&quot; prefix is already present in the FIND_PATH() argument \
&quot;readline/readline.h&quot;, so it should be cut off the path; 2. \
&quot;/usr/include&quot; is in standard search path for CMake.

This is probably a leftover from times when analitza tried to use \
&quot;readline.h&quot; instead of &quot;readline/readline.h&quot;.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">OpenBSD/i386-CURRENT</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/FindReadline.cmake <span style="color: grey">(8fc21ec)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118957/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 