'Re: Review Request 117878: Implements a luajit backend for Cantor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 117878: Implements a luajit backend for Cantor
From:       "Lucas Hermann Negri" <lucashnegri () gmail ! com>
Date:       2014-05-09 1:51:15
Message-ID: 20140509015115.11253.87349 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117878/
-----------------------------------------------------------

(Updated May 9, 2014, 1:51 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.

Repository: cantor

Description
-------

Implements a luajit backend for Cantor. Implements highlighting, completion, and \
other features (variable explorer is missing).

Is compatible with Lua science/math libraries like numlua[1] and lna[2].

[1]: https://github.com/carvalho/numlua
[2]: https://bitbucket.org/lucashnegri/lna

Diffs
-----

  cmake/FindLuaJIT.cmake PRE-CREATION 
  icons/hi48-app-luabackend.png PRE-CREATION 
  src/backends/CMakeLists.txt e89d9e6 
  src/backends/lua/CMakeLists.txt PRE-CREATION 
  src/backends/lua/luabackend.cpp PRE-CREATION 
  src/backends/lua/luabackend.desktop PRE-CREATION 
  src/backends/lua/luabackend.h PRE-CREATION 
  src/backends/lua/luabackend.kcfg PRE-CREATION 
  src/backends/lua/luacompletionobject.h PRE-CREATION 
  src/backends/lua/luacompletionobject.cpp PRE-CREATION 
  src/backends/lua/luaexpression.h PRE-CREATION 
  src/backends/lua/luaexpression.cpp PRE-CREATION 
  src/backends/lua/luaextensions.h PRE-CREATION 
  src/backends/lua/luaextensions.cpp PRE-CREATION 
  src/backends/lua/luahelper.h PRE-CREATION 
  src/backends/lua/luahelper.cpp PRE-CREATION 
  src/backends/lua/luahighlighter.h PRE-CREATION 
  src/backends/lua/luahighlighter.cpp PRE-CREATION 
  src/backends/lua/luasession.h PRE-CREATION 
  src/backends/lua/luasession.cpp PRE-CREATION 
  src/backends/lua/settings.kcfgc PRE-CREATION 
  src/backends/lua/settings.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117878/diff/

Testing
-------

Basic testing performed manually. Everything seems to work as expected.

Thanks,

Lucas Hermann Negri

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117878/">https://git.reviewboard.kde.org/r/117878/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.</div>
<div>By Lucas Hermann Negri.</div>

<p style="color: grey;"><i>Updated May 9, 2014, 1:51 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implements a luajit backend for Cantor. Implements highlighting, \
completion, and other features (variable explorer is missing).

Is compatible with Lua science/math libraries like numlua[1] and lna[2].

[1]: https://github.com/carvalho/numlua
[2]: https://bitbucket.org/lucashnegri/lna</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Basic testing performed manually. Everything seems to work as \
expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/FindLuaJIT.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>icons/hi48-app-luabackend.png <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/CMakeLists.txt <span style="color: grey">(e89d9e6)</span></li>

 <li>src/backends/lua/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luabackend.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luacompletionobject.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luacompletionobject.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaexpression.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaexpression.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaextensions.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luaextensions.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahelper.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahelper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahighlighter.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luahighlighter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luasession.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/luasession.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/settings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/backends/lua/settings.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117878/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 