'Re: Review Request 116629: Parley plugin mwclient bug workaround: using'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 116629: Parley plugin mwclient bug workaround: using
From:       "Maximilian Reiner" <max.reiner () googlemail ! com>
Date:       2014-04-23 23:06:04
Message-ID: 20140423230604.8845.54215 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116629/
-----------------------------------------------------------

(Updated April 23, 2014, 11:06 p.m.)

Review request for KDE Edu and Inge Wallin.

Changes
-------

Inge can you please review this? Maximilian did the mistake of giving himself a "Ship \
it" but still deserves a review :.)

Repository: parley

Description
-------

Parley plugin mwclient bug workaround: fetching content by calling \
wikiObject.download() raised a http 404 error, but urllib's open/read method works as \
expected on an existing URI.

Diffs
-----

  plugins/wiktionary/wiktionary_sound.py 92074bf 

Diff: https://git.reviewboard.kde.org/r/116629/diff/

Testing
-------

Using urlopen/read from the standard urllib library delivers object's content with \
http status 200 OK.

Thanks,

Maximilian Reiner

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116629/">https://git.reviewboard.kde.org/r/116629/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By Maximilian Reiner.</div>

<p style="color: grey;"><i>Updated April 23, 2014, 11:06 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Inge can you please review this? Maximilian did the mistake of giving \
himself a &quot;Ship it&quot; but still deserves a review :.)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Parley plugin mwclient bug workaround: fetching content by calling \
wikiObject.download() raised a http 404 error, but urllib&#39;s open/read method \
works as expected on an existing URI. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using urlopen/read from the standard urllib library delivers \
object&#39;s content with http status 200 OK.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/wiktionary/wiktionary_sound.py <span style="color: \
grey">(92074bf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116629/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 