[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 115758: Add sound to kgeography
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-04-23 23:03:16
Message-ID: 20140423230316.8845.26921 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115758/#review56338
-----------------------------------------------------------
Jaime?
- Albert Astals Cid
On Feb. 17, 2014, 7:47 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115758/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2014, 7:47 p.m.)
>
>
> Review request for KDE Edu and Albert Astals Cid.
>
>
> Bugs: 132702
> http://bugs.kde.org/show_bug.cgi?id=132702
>
>
> Repository: kgeography
>
>
> Description
> -------
>
> The code to choose the sound file is borrowed from kalarm.
> Add phonon to play sounds (can not be easier).
> Add the configuration to select the sound files.
>
>
> Diffs
> -----
>
> CMakeLists.txt e7a6d9c
> src/CMakeLists.txt 9e49f0d
> src/askwidget.h 32421b0
> src/askwidget.cpp 7f9e3cc
> src/boxasker.h 507099f
> src/boxasker.cpp f0a5b60
> src/capitaldivisionasker.h 744c43c
> src/capitaldivisionasker.cpp 495eb26
> src/divisioncapitalasker.h 0246482
> src/divisioncapitalasker.cpp 625379b
> src/divisionflagasker.h ffee8c2
> src/divisionflagasker.cpp 361c973
> src/flagdivisionasker.h 623a249
> src/flagdivisionasker.cpp 34f7711
> src/kgeography.h 4506bd0
> src/kgeography.cpp e5e5305
> src/kgeography.kcfg 14f5d4f
> src/kgeographyoptions.ui 109b077
> src/mapasker.h 4e89fe5
> src/mapasker.cpp 22e0c24
> src/placeasker.h 7d27178
> src/placeasker.cpp d65e030
>
> Diff: https://git.reviewboard.kde.org/r/115758/diff/
>
>
> Testing
> -------
>
> It only make sounds when selected in the configuration, and the sound file exists.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115758/">https://git.reviewboard.kde.org/r/115758/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Jaime?</pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On February 17th, 2014, 7:47 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2014, 7:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=132702">132702</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The code to choose the sound file is borrowed from kalarm. Add phonon to \
play sounds (can not be easier). Add the configuration to select the sound \
files.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It only make sounds when selected in the configuration, and the sound \
file exists.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e7a6d9c)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(9e49f0d)</span></li>
<li>src/askwidget.h <span style="color: grey">(32421b0)</span></li>
<li>src/askwidget.cpp <span style="color: grey">(7f9e3cc)</span></li>
<li>src/boxasker.h <span style="color: grey">(507099f)</span></li>
<li>src/boxasker.cpp <span style="color: grey">(f0a5b60)</span></li>
<li>src/capitaldivisionasker.h <span style="color: grey">(744c43c)</span></li>
<li>src/capitaldivisionasker.cpp <span style="color: grey">(495eb26)</span></li>
<li>src/divisioncapitalasker.h <span style="color: grey">(0246482)</span></li>
<li>src/divisioncapitalasker.cpp <span style="color: grey">(625379b)</span></li>
<li>src/divisionflagasker.h <span style="color: grey">(ffee8c2)</span></li>
<li>src/divisionflagasker.cpp <span style="color: grey">(361c973)</span></li>
<li>src/flagdivisionasker.h <span style="color: grey">(623a249)</span></li>
<li>src/flagdivisionasker.cpp <span style="color: grey">(34f7711)</span></li>
<li>src/kgeography.h <span style="color: grey">(4506bd0)</span></li>
<li>src/kgeography.cpp <span style="color: grey">(e5e5305)</span></li>
<li>src/kgeography.kcfg <span style="color: grey">(14f5d4f)</span></li>
<li>src/kgeographyoptions.ui <span style="color: grey">(109b077)</span></li>
<li>src/mapasker.h <span style="color: grey">(4e89fe5)</span></li>
<li>src/mapasker.cpp <span style="color: grey">(22e0c24)</span></li>
<li>src/placeasker.h <span style="color: grey">(7d27178)</span></li>
<li>src/placeasker.cpp <span style="color: grey">(d65e030)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115758/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic