'Re: Review Request 116811: Autorun scripts support to Octave backend'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 116811: Autorun scripts support to Octave backend
From:       "Filipe Saraiva" <filipe () kde ! org>
Date:       2014-03-30 16:59:37
Message-ID: 20140330165937.20889.44121 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116811/
-----------------------------------------------------------

(Updated March 30, 2014, 4:59 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Alexander Rieder.

Repository: cantor

Description
-------

Added autorun scripts support to Octave backend

Hi Alex and kdeedu team, I am developing autorun scripts supports to some backends. \
This scripts are loaded when Cantor load a backend - it is based on R-backend. It is \
the support to Octave. I did some tests and it worked very well.

I would like to request a review in this code to you.

Thanks.

Diffs
-----

  src/backends/octave/octavebackend.kcfg cea1a89 
  src/backends/octave/octavesession.cpp ebb156a 
  src/backends/octave/settings.ui e245632 

Diff: https://git.reviewboard.kde.org/r/116811/diff/

Testing
-------

Open Octave backend, go to Settings -> Cantor's Settings -> Octave and add some \
commands. Close Cantor and open it again, selecting Octave backend.
See if the commands were executed.

Thanks,

Filipe Saraiva

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116811/">https://git.reviewboard.kde.org/r/116811/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>

<p style="color: grey;"><i>Updated March 30, 2014, 4:59 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added autorun scripts support to Octave backend

Hi Alex and kdeedu team, I am developing autorun scripts supports to some backends. \
This scripts are loaded when Cantor load a backend - it is based on R-backend. It is \
the support to Octave. I did some tests and it worked very well.

I would like to request a review in this code to you.

Thanks.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Open Octave backend, go to Settings -&gt; Cantor&#39;s Settings -&gt; \
Octave and add some commands. Close Cantor and open it again, selecting Octave \
backend. See if the commands were executed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/octave/octavebackend.kcfg <span style="color: \
grey">(cea1a89)</span></li>

 <li>src/backends/octave/octavesession.cpp <span style="color: \
grey">(ebb156a)</span></li>

 <li>src/backends/octave/settings.ui <span style="color: grey">(e245632)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116811/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 