[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 116631: Avoid the unneeded use of rpath
From: "Commit Hook" <null () kde ! org>
Date: 2014-03-19 22:49:26
Message-ID: 20140319224926.13090.98689 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116631/#review53468
-----------------------------------------------------------
This review has been submitted with commit 3bed50a2608ed28e92e9002b955df3bf3282728c \
by Alexander Rieder to branch master.
- Commit Hook
On March 19, 2014, 10:46 p.m., Maximiliano Curia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116631/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 10:46 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: cantor
>
>
> Description
> -------
>
> Hi,
>
> This patch was originally created by Modestas Vainius <modax@debian.org>
>
> I'm not sure why is that cantor R support uses rpath, but is not needed, please \
> avoid it.
>
> Diffs
> -----
>
> src/backends/R/CMakeLists.txt 5da002675f1c3e4a5feef7ef82dc54b90289cbac
> src/backends/R/rserver/CMakeLists.txt 4f9ca903a49eba98afd2fbc05e20a87652be2f93
>
> Diff: https://git.reviewboard.kde.org/r/116631/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maximiliano Curia
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116631/">https://git.reviewboard.kde.org/r/116631/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3bed50a2608ed28e92e9002b955df3bf3282728c by Alexander Rieder to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On March 19th, 2014, 10:46 p.m. UTC, Maximiliano Curia wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Maximiliano Curia.</div>
<p style="color: grey;"><i>Updated March 19, 2014, 10:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
This patch was originally created by Modestas Vainius <modax@debian.org>
I'm not sure why is that cantor R support uses rpath, but is not needed, please \
avoid it. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/R/CMakeLists.txt <span style="color: \
grey">(5da002675f1c3e4a5feef7ef82dc54b90289cbac)</span></li>
<li>src/backends/R/rserver/CMakeLists.txt <span style="color: \
grey">(4f9ca903a49eba98afd2fbc05e20a87652be2f93)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116631/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic