[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 116660: Implement fixed sessions for Parley
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2014-03-09 16:51:44
Message-ID: 20140309165144.7788.5443 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116660/
-----------------------------------------------------------
(Updated March 9, 2014, 4:51 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu and Amarvir Singh.
Repository: parley
Description
-------
This patch implement fixed sessions for Parley. With that I mean that training is \
split up into sessions with a fixed number maximum number of words. The default value \
for the number is 20 but it could also be fewer. At most 5 of those can be new words, \
so it also makes it easier to learn new vocabulary by not allowing an unwieldy number \
of new words at a time. Before this patch a session was all the words that were due \
based on time since last practice and grade, which meant that a session could \
potentially consist of thousands of words.
Technically this patch works by splitting the old SessionManager into a base class \
(SessionManagerBase) and a specific class (SessionManagerContinuous) and then \
implementing a new class SessionManagerFixed. The SessionManager was recently \
renamed into that name from the old TestEntryManager which didn't describe what it \
did at all.
This is the first milestone in the project to create a new session system. Step 2 \
will be with adding some configuration and step 3 will be a new graphic look.
Note that in this version of the patch the numbers 20 (max size) and 5 (max new \
words) are replaced with 7 and 3 to make testing easier.
Diffs
-----
src/settings/languagepropertiespage.cpp e324167
src/practice/writtenpracticevalidator.h d38190e
src/practice/writtenbackendmode.cpp 4cb723e
src/practice/sessionmanagerfixed.cpp PRE-CREATION
src/practice/writtenbackendmode.h dd8d3ee
src/practice/sessionmanagerfixed.h PRE-CREATION
src/practice/sessionmanagercontinuous.cpp PRE-CREATION
src/practice/sessionmanagercontinuous.h PRE-CREATION
src/practice/sessionmanagerbase.cpp PRE-CREATION
src/practice/sessionmanagerbase.h PRE-CREATION
src/practice/sessionmanager.cpp adea30b
TODO-SESSIONS PRE-CREATION
src/CMakeLists.txt 03d05ee
src/configure-practice/blockoptions.h 1882994
src/configure-practice/thresholdoptions.cpp 1fb55e1
src/parleymainwindow.h 318312c
src/parleymainwindow.cpp 1672647
src/practice/DESIGN 99d4c0b
src/practice/comparisonbackendmode.h e5cb5d0
src/practice/comparisonbackendmode.cpp a3efac8
src/practice/conjugationbackendmode.h 8cc59ee
src/practice/conjugationbackendmode.cpp fa365d9
src/practice/examplesentencebackendmode.h 38941e1
src/practice/examplesentencebackendmode.cpp 0cc812c
src/practice/genderbackendmode.h 9a4a28a
src/practice/genderbackendmode.cpp b2cc7c1
src/practice/multiplechoicebackendmode.h a77265e
src/practice/multiplechoicebackendmode.cpp 51f35a3
src/practice/practicemainwindow.h 93fcd66
src/practice/practicemainwindow.cpp 6fe7aa1
src/practice/practicestatemachine.h 81cff91
src/practice/practicestatemachine.cpp 16f86c1
src/practice/practicesummarycomponent.h 41cc83b
src/practice/practicesummarycomponent.cpp bffb584
src/practice/sessionmanager.h 64e70c9
Diff: https://git.reviewboard.kde.org/r/116660/diff/
Testing
-------
Tested with a special version of a word list I am working with. I will attach it \
here.
File Attachments
----------------
A small test file
https://git.reviewboard.kde.org/media/uploaded/files/2014/03/08/f5213df1-cfe8-44cc-9d16-c2956bf39076__Thai-numbers-copy.kvtml
Thanks,
Inge Wallin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116660/">https://git.reviewboard.kde.org/r/116660/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Amarvir Singh.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated March 9, 2014, 4:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implement fixed sessions for Parley. With that I mean that \
training is split up into sessions with a fixed number maximum number of words. The \
default value for the number is 20 but it could also be fewer. At most 5 of those can \
be new words, so it also makes it easier to learn new vocabulary by not allowing an \
unwieldy number of new words at a time. Before this patch a session was all the words \
that were due based on time since last practice and grade, which meant that a session \
could potentially consist of thousands of words.
Technically this patch works by splitting the old SessionManager into a base class \
(SessionManagerBase) and a specific class (SessionManagerContinuous) and then \
implementing a new class SessionManagerFixed. The SessionManager was recently \
renamed into that name from the old TestEntryManager which didn't describe what \
it did at all.
This is the first milestone in the project to create a new session system. Step 2 \
will be with adding some configuration and step 3 will be a new graphic look.
Note that in this version of the patch the numbers 20 (max size) and 5 (max new \
words) are replaced with 7 and 3 to make testing easier.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with a special version of a word list I am working with. I will \
attach it here.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/settings/languagepropertiespage.cpp <span style="color: \
grey">(e324167)</span></li>
<li>src/practice/writtenpracticevalidator.h <span style="color: \
grey">(d38190e)</span></li>
<li>src/practice/writtenbackendmode.cpp <span style="color: \
grey">(4cb723e)</span></li>
<li>src/practice/sessionmanagerfixed.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/writtenbackendmode.h <span style="color: \
grey">(dd8d3ee)</span></li>
<li>src/practice/sessionmanagerfixed.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/sessionmanagercontinuous.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/sessionmanagercontinuous.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/sessionmanagerbase.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/sessionmanagerbase.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/practice/sessionmanager.cpp <span style="color: grey">(adea30b)</span></li>
<li>TODO-SESSIONS <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(03d05ee)</span></li>
<li>src/configure-practice/blockoptions.h <span style="color: \
grey">(1882994)</span></li>
<li>src/configure-practice/thresholdoptions.cpp <span style="color: \
grey">(1fb55e1)</span></li>
<li>src/parleymainwindow.h <span style="color: grey">(318312c)</span></li>
<li>src/parleymainwindow.cpp <span style="color: grey">(1672647)</span></li>
<li>src/practice/DESIGN <span style="color: grey">(99d4c0b)</span></li>
<li>src/practice/comparisonbackendmode.h <span style="color: \
grey">(e5cb5d0)</span></li>
<li>src/practice/comparisonbackendmode.cpp <span style="color: \
grey">(a3efac8)</span></li>
<li>src/practice/conjugationbackendmode.h <span style="color: \
grey">(8cc59ee)</span></li>
<li>src/practice/conjugationbackendmode.cpp <span style="color: \
grey">(fa365d9)</span></li>
<li>src/practice/examplesentencebackendmode.h <span style="color: \
grey">(38941e1)</span></li>
<li>src/practice/examplesentencebackendmode.cpp <span style="color: \
grey">(0cc812c)</span></li>
<li>src/practice/genderbackendmode.h <span style="color: grey">(9a4a28a)</span></li>
<li>src/practice/genderbackendmode.cpp <span style="color: \
grey">(b2cc7c1)</span></li>
<li>src/practice/multiplechoicebackendmode.h <span style="color: \
grey">(a77265e)</span></li>
<li>src/practice/multiplechoicebackendmode.cpp <span style="color: \
grey">(51f35a3)</span></li>
<li>src/practice/practicemainwindow.h <span style="color: \
grey">(93fcd66)</span></li>
<li>src/practice/practicemainwindow.cpp <span style="color: \
grey">(6fe7aa1)</span></li>
<li>src/practice/practicestatemachine.h <span style="color: \
grey">(81cff91)</span></li>
<li>src/practice/practicestatemachine.cpp <span style="color: \
grey">(16f86c1)</span></li>
<li>src/practice/practicesummarycomponent.h <span style="color: \
grey">(41cc83b)</span></li>
<li>src/practice/practicesummarycomponent.cpp <span style="color: \
grey">(bffb584)</span></li>
<li>src/practice/sessionmanager.h <span style="color: grey">(64e70c9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116660/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/08/f5213df1-cfe8-44cc-9d16-c2956bf39076__Thai-numbers-copy.kvtml">A \
small test file</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic