[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 116095: Loading images with Parley Google images plugin's
From: "Amarvir Singh" <amarvir.ammu.93 () gmail ! com>
Date: 2014-02-28 17:50:54
Message-ID: 20140228175054.29080.95246 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 28, 2014, 9:22 p.m., Amarvir Singh wrote:
> > Thank you for the patch. But, there were a few conflicts. So, please perform a \
> > 'rebase' after 'pulling' the latest changes and then send an updated patch. Also, \
> > I'd recommend using git diff or git format-patch. Easier to use and apply :)
>
> Yuri Chornoivan wrote:
> In fact, the current code does load the images (but pre 4.11 versions do not):
>
> https://git.reviewboard.kde.org/r/112285/
>
> Though this approach may be better, it implicitly add dependencies on var_dump \
> Python package (not available for all distributions).
> Amarvir Singh wrote:
> Oh, I wasn't aware of that. But, I tried using the 'Fetch Image' script on a word \
> 'Camera'. It opens up a dialog asking for the keyword. But clicking on search or \
> even next causes the script to hang at "parsing data. Something wrong?
> Yuri Chornoivan wrote:
> Oops... Yes, Google broke it again...
>
> But can it work without var_dump?
Well, let's wait for Maximilian to update the patch and answer this. I don't know \
much about python, but if it's like PHP's use (which I think it is), a simple Google \
search does reveal an alternative of using 'pprint' or something like 'print \
var(foo)'.
- Amarvir
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116095/#review51346
-----------------------------------------------------------
On Feb. 28, 2014, 5:17 p.m., Maximilian Reiner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116095/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2014, 5:17 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: parley
>
>
> Description
> -------
>
> Parley Google images plugin fails loading images with in-built screen scraper.
> Simple RESTful image search with Google's API seems to be more preferable to do \
> this.
>
> Diffs
> -----
>
> google_images.orig 5317ba6
>
> Diff: https://git.reviewboard.kde.org/r/116095/diff/
>
>
> Testing
> -------
>
> Loading images with Google JSON AJAX API succeeded.
>
>
> Thanks,
>
> Maximilian Reiner
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116095/">https://git.reviewboard.kde.org/r/116095/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 28th, 2014, 9:22 p.m. IST, <b>Amarvir \
Singh</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thank you for the patch. But, there were a few conflicts. So, please \
perform a 'rebase' after 'pulling' the latest changes and then send \
an updated patch. Also, I'd recommend using git diff or git format-patch. Easier \
to use and apply :)</pre> </blockquote>
<p>On February 28th, 2014, 10:17 p.m. IST, <b>Yuri Chornoivan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In fact, the current \
code does load the images (but pre 4.11 versions do not):
https://git.reviewboard.kde.org/r/112285/
Though this approach may be better, it implicitly add dependencies on var_dump Python \
package (not available for all distributions).</pre> </blockquote>
<p>On February 28th, 2014, 10:34 p.m. IST, <b>Amarvir Singh</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, I wasn't aware \
of that. But, I tried using the 'Fetch Image' script on a word \
'Camera'. It opens up a dialog asking for the keyword. But clicking on search \
or even next causes the script to hang at "parsing data. Something wrong?</pre> \
</blockquote>
<p>On February 28th, 2014, 10:38 p.m. IST, <b>Yuri Chornoivan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops... Yes, Google \
broke it again...
But can it work without var_dump?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, let's wait for \
Maximilian to update the patch and answer this. I don't know much about python, \
but if it's like PHP's use (which I think it is), a simple Google search does \
reveal an alternative of using 'pprint' or something like 'print \
var(foo)'.</pre> <br />
<p>- Amarvir</p>
<br />
<p>On February 28th, 2014, 5:17 p.m. IST, Maximilian Reiner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Maximilian Reiner.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2014, 5:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Parley Google images plugin fails loading images with in-built screen \
scraper. Simple RESTful image search with Google's API seems to be more \
preferable to do this. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loading images with Google JSON AJAX API succeeded. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>google_images.orig <span style="color: grey">(5317ba6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116095/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic