[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 115601: [parley][PATCH] Fixes the editor dock widgets leaking out of screen and b
From: "Amarvir Singh" <amarvir.ammu.93 () gmail ! com>
Date: 2014-02-25 20:12:07
Message-ID: 20140225201207.20335.32248 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115601/
-----------------------------------------------------------
(Updated Feb. 25, 2014, 8:12 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Repository: parley
Description
-------
Fixes the bug that caused widgets in the editor to leak out of the bottom of the \
screen, if multiple widgets were selected in view, making them inaccessible. The bug \
didn't allow the screen to be resized either as the dock widgets could not be made \
smaller. This made it an annoying bug, as it didn't allow the user to simply resize \
the window to access the cutoff widgets. They had to be closed, and the window had to \
be minimized-maximized to restructure the dock widgets.
Steps to reproduce:
1. Go to editor mode.
2. View->add multiple widgets (eg synonyms, antonyms, image, latex, etc.)
3. The widgets start leaking out even in a Full HD screen, and some, hence, become \
inaccessible. 4. Try resizing window (decreasing size from the top), doesnt work, as \
QDockWidgets take a defined space.
Expected Result:
Widgets should not be cutoff, and resizing should be possible.
This commit makes each widget scrollable so that they can be reduced in size, to \
allow the window to be made smaller. Also they are tabbed together, to ensure widgets \
don't leak out, even for lower resolutions, and it also ensures that they remain \
accessible.
PS: To properly check for the changes in the dockwidgets after the patch, be sure to \
not use the configuration saved, rename it or delete it, or just rename kdehome \
directory. This is because dockwidget positions and layout is saved. Then continue \
adding all widgets.
Diffs
-----
src/editor/editor.cpp f2ec266
Diff: https://git.reviewboard.kde.org/r/115601/diff/
Testing
-------
Tested, from 1920x1080 to 800x600 resolutions.
Thanks,
Amarvir Singh
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115601/">https://git.reviewboard.kde.org/r/115601/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Amarvir Singh.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 8:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the bug that caused widgets in the editor to leak out of the \
bottom of the screen, if multiple widgets were selected in view, making them \
inaccessible. The bug didn't allow the screen to be resized either as the dock \
widgets could not be made smaller. This made it an annoying bug, as it didn't \
allow the user to simply resize the window to access the cutoff widgets. They had to \
be closed, and the window had to be minimized-maximized to restructure the dock \
widgets.
Steps to reproduce:
1. Go to editor mode.
2. View->add multiple widgets (eg synonyms, antonyms, image, latex, etc.)
3. The widgets start leaking out even in a Full HD screen, and some, hence, become \
inaccessible. 4. Try resizing window (decreasing size from the top), doesnt work, as \
QDockWidgets take a defined space.
Expected Result:
Widgets should not be cutoff, and resizing should be possible.
This commit makes each widget scrollable so that they can be reduced in size, to \
allow the window to be made smaller. Also they are tabbed together, to ensure widgets \
don't leak out, even for lower resolutions, and it also ensures that they remain \
accessible.
PS: To properly check for the changes in the dockwidgets after the patch, be sure to \
not use the configuration saved, rename it or delete it, or just rename kdehome \
directory. This is because dockwidget positions and layout is saved. Then continue \
adding all widgets.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, from 1920x1080 to 800x600 resolutions. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/editor/editor.cpp <span style="color: grey">(f2ec266)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115601/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic