'Re: Review Request 115965: [patch][parley] Adds sound support for multiple modes and fixes it in oth'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 115965: [patch][parley] Adds sound support for multiple modes and fixes it in oth
From:       "Amarvir Singh" <amarvir.ammu.93 () gmail ! com>
Date:       2014-02-24 17:50:03
Message-ID: 20140224175003.13755.79584 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115965/
-----------------------------------------------------------

(Updated Feb. 24, 2014, 5:50 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Inge Wallin.

Repository: parley

Description
-------

This:
1. Adds support for sound in Multiple Choice and Example Sentences modes.
2. Causes the audio to stop on answering and changing questions in all modes.
3. Changes audio button sizes in all modes.

Diffs
-----

  src/practice/abstractfrontend.h e0c6a87 
  src/practice/flashcardmodewidget.cpp 1628377 
  src/practice/guifrontend.cpp 2b09658 
  src/practice/multiplechoicemodewidget.cpp 3ead1eb 
  src/practice/practice_widget_flashcard.ui e7275c7 
  src/practice/practice_widget_multiplechoice.ui 1c70e12 
  src/practice/practice_widget_written.ui b4ca2e7 
  src/practice/practicestatemachine.cpp 00b1f20 
  src/practice/writtenpracticewidget.h ceda8e8 
  src/practice/writtenpracticewidget.cpp da28f67 

Diff: https://git.reviewboard.kde.org/r/115965/diff/

Testing
-------

Tested and working.

Thanks,

Amarvir Singh

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115965/">https://git.reviewboard.kde.org/r/115965/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By Amarvir Singh.</div>

<p style="color: grey;"><i>Updated Feb. 24, 2014, 5:50 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This: 1. Adds support for sound in Multiple Choice and Example Sentences \
modes. 2. Causes the audio to stop on answering and changing questions in all modes.
3. Changes audio button sizes in all modes.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and working.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/practice/abstractfrontend.h <span style="color: grey">(e0c6a87)</span></li>

 <li>src/practice/flashcardmodewidget.cpp <span style="color: \
grey">(1628377)</span></li>

 <li>src/practice/guifrontend.cpp <span style="color: grey">(2b09658)</span></li>

 <li>src/practice/multiplechoicemodewidget.cpp <span style="color: \
grey">(3ead1eb)</span></li>

 <li>src/practice/practice_widget_flashcard.ui <span style="color: \
grey">(e7275c7)</span></li>

 <li>src/practice/practice_widget_multiplechoice.ui <span style="color: \
grey">(1c70e12)</span></li>

 <li>src/practice/practice_widget_written.ui <span style="color: \
grey">(b4ca2e7)</span></li>

 <li>src/practice/practicestatemachine.cpp <span style="color: \
grey">(00b1f20)</span></li>

 <li>src/practice/writtenpracticewidget.h <span style="color: \
grey">(ceda8e8)</span></li>

 <li>src/practice/writtenpracticewidget.cpp <span style="color: \
grey">(da28f67)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115965/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 