'Re: Review Request 115621: [parley][PATCH] Fixes the problem of audio player not stopping when conti'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 115621: [parley][PATCH] Fixes the problem of audio player not stopping when conti
From:       "Amarvir Singh" <amarvir.ammu.93 () gmail ! com>
Date:       2014-02-21 19:30:19
Message-ID: 20140221193019.27042.92353 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115621/
-----------------------------------------------------------

(Updated Feb. 22, 2014, 1 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Repository: parley

Description
-------

This bug present was present in the written and mixed letters practice modes which \
contained the audio player. The audio never stopped when continue was pressed, \
neither for the questionSound nor the solutionSound. In case of longer sound clips \
(sentences or multiple words) this usually meant that the sound played even when the \
next question appeared. This was usually the case when the answer was not known and \
the user simply pressed enter or clicked on continue. The user had to wait for the \
sound to stop or manually click on stop button, to stop the audio. This meant that \
the user could not directly hear the new question's audio, without stopping the \
previous sound.

Steps to reproduce:
1. Set the vocabulary to contain audio for words.
2. Start written practice mode.
3. Quickly press enter or click on continue as if you dont know the answer (longer \
audio helps) 4. The sound continues to play even in the next question, and playing \
the next question's audio requires you to wait for it to stop.

Expected Result:
Audio stops on pressing continue.

This patch fixes this bug and stops the currently playing sound using a stopAudio \
signal as soon as the continue button is pressed or enter is hit, after answering.

Diffs
-----

  src/practice/writtenpracticewidget.cpp 05e2a16 
  src/practice/abstractwidget.h 3156b17 
  src/practice/audiobutton.h abebaf4 
  src/practice/audiobutton.cpp 2aae366 

Diff: https://git.reviewboard.kde.org/r/115621/diff/

Testing
-------

Tested for written and mixed letters modes.

Thanks,

Amarvir Singh

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115621/">https://git.reviewboard.kde.org/r/115621/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Amarvir Singh.</div>

<p style="color: grey;"><i>Updated Feb. 22, 2014, 1 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This bug present was present in the written and mixed letters practice \
modes which contained the audio player. The audio never stopped when continue was \
pressed, neither for the questionSound nor the solutionSound. In case of longer sound \
clips (sentences or multiple words) this usually meant that the sound played even \
when the next question appeared. This was usually the case when the answer was not \
known and the user simply pressed enter or clicked on continue. The user had to wait \
for the sound to stop or manually click on stop button, to stop the audio. This meant \
that the user could not directly hear the new question&#39;s audio, without stopping \
the previous sound.

Steps to reproduce:
1. Set the vocabulary to contain audio for words.
2. Start written practice mode.
3. Quickly press enter or click on continue as if you dont know the answer (longer \
audio helps) 4. The sound continues to play even in the next question, and playing \
the next question&#39;s audio requires you to wait for it to stop.

Expected Result:
Audio stops on pressing continue.

This patch fixes this bug and stops the currently playing sound using a stopAudio \
signal as soon as the continue button is pressed or enter is hit, after \
answering.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested for written and mixed letters modes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/practice/writtenpracticewidget.cpp <span style="color: \
grey">(05e2a16)</span></li>

 <li>src/practice/abstractwidget.h <span style="color: grey">(3156b17)</span></li>

 <li>src/practice/audiobutton.h <span style="color: grey">(abebaf4)</span></li>

 <li>src/practice/audiobutton.cpp <span style="color: grey">(2aae366)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115621/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 