[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 115892: Implement sound support for flashcard practice mode
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2014-02-19 20:05:26
Message-ID: 20140219200526.5175.29505 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115892/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 8:05 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu and Amarvir Singh.
Repository: parley
Description
-------
This patch implements sounds support for flashcards in Parley.
I started to play around a bit and see how it was done in the written words practice \
mode and then I just copied relevant parts of the code and the ui file. And behold! \
It actually works.
There seems to be a bug in there that makes the sound button for the solution to \
sometimes appear and sometimes not, but I think that is a bug in the engine rather \
than in the flashcard class. There is also a bug that makes the sound button itself \
stay in the "playing" state much longer than is warranted by the size of the sound \
file. But that is also not in the new code (it's also present in the previous \
practice modes that supported sound).
Diffs
-----
TODO b264925
src/practice/flashcardmodewidget.cpp 9d7ee9f
src/practice/practice_widget_flashcard.ui c43a528
Diff: https://git.reviewboard.kde.org/r/115892/diff/
Testing
-------
Created a test file with some sounds in it and practiced that N times.
Thanks,
Inge Wallin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115892/">https://git.reviewboard.kde.org/r/115892/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Amarvir Singh.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2014, 8:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements sounds support for flashcards in Parley.
I started to play around a bit and see how it was done in the written words practice \
mode and then I just copied relevant parts of the code and the ui file. And behold! \
It actually works.
There seems to be a bug in there that makes the sound button for the solution to \
sometimes appear and sometimes not, but I think that is a bug in the engine rather \
than in the flashcard class. There is also a bug that makes the sound button itself \
stay in the "playing" state much longer than is warranted by the size of \
the sound file. But that is also not in the new code (it's also present in the \
previous practice modes that supported sound).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created a test file with some sounds in it and practiced that N \
times.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>TODO <span style="color: grey">(b264925)</span></li>
<li>src/practice/flashcardmodewidget.cpp <span style="color: \
grey">(9d7ee9f)</span></li>
<li>src/practice/practice_widget_flashcard.ui <span style="color: \
grey">(c43a528)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115892/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic