'Re: Review Request 115758: Add sound to kgeography'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 115758: Add sound to kgeography
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2014-02-18 9:53:11
Message-ID: 20140218095311.430.21688 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Feb. 17, 2014, 10:49 p.m., Albert Astals Cid wrote:
> > Please use tabs as the rest of the code uses.

I will check in another editor, it shows the ">>" symbol in kdevelop. (except in the \
methods copied from kalarm, I'll change them).

> On Feb. 17, 2014, 10:49 p.m., Albert Astals Cid wrote:
> > CMakeLists.txt, line 14
> > <https://git.reviewboard.kde.org/r/115758/diff/4/?file=244606#file244606line14>
> > 
> > There's two sounds folders? One here and one in src? Maybe you can attach to the \
> > bug the files they contain so i can actually test this?

I'm not sure if it should have its own sound files. The open file dialog now goes to \
KDE default sound files folder. Should it point to its own sound directory (If I find \
the KDE_Glass_Break.ogg)? But, yes, in any case, one (or zero) sound directory is \
enough. By the way, I do not have the KDE_Glass_Break.ogg file in KDE4 sources \
(including kdeartwork). Will search at home. Was it a KDE 3 file?

> On Feb. 17, 2014, 10:49 p.m., Albert Astals Cid wrote:
> > src/kgeography.kcfg, line 44
> > <https://git.reviewboard.kde.org/r/115758/diff/4/?file=244622#file244622line44>
> > 
> > Do you think it makes sense this to be enabled by default? I am not sure

I'm not sure also, but the bug report say it should be enabled by default. So I'll \
change it.

- Jaime Torres

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115758/#review50112
-----------------------------------------------------------

On Feb. 17, 2014, 7:47 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115758/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 7:47 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 132702
> http://bugs.kde.org/show_bug.cgi?id=132702
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> The code to choose the sound file is borrowed from kalarm.
> Add phonon to play sounds (can not be easier).
> Add the configuration to select the sound files.
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt e7a6d9c 
> src/CMakeLists.txt 9e49f0d 
> src/askwidget.h 32421b0 
> src/askwidget.cpp 7f9e3cc 
> src/boxasker.h 507099f 
> src/boxasker.cpp f0a5b60 
> src/capitaldivisionasker.h 744c43c 
> src/capitaldivisionasker.cpp 495eb26 
> src/divisioncapitalasker.h 0246482 
> src/divisioncapitalasker.cpp 625379b 
> src/divisionflagasker.h ffee8c2 
> src/divisionflagasker.cpp 361c973 
> src/flagdivisionasker.h 623a249 
> src/flagdivisionasker.cpp 34f7711 
> src/kgeography.h 4506bd0 
> src/kgeography.cpp e5e5305 
> src/kgeography.kcfg 14f5d4f 
> src/kgeographyoptions.ui 109b077 
> src/mapasker.h 4e89fe5 
> src/mapasker.cpp 22e0c24 
> src/placeasker.h 7d27178 
> src/placeasker.cpp d65e030 
> 
> Diff: https://git.reviewboard.kde.org/r/115758/diff/
> 
> 
> Testing
> -------
> 
> It only make sounds when selected in the configuration, and the sound file exists.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115758/">https://git.reviewboard.kde.org/r/115758/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 17th, 2014, 10:49 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Please use tabs as the rest of the code uses.</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will check in another \
editor, it shows the &quot;&gt;&gt;&quot; symbol in kdevelop. (except in the methods \
copied from kalarm, I&#39;ll change them).</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 17th, 2014, 10:49 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/115758/diff/4/?file=244606#file244606line14" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">14</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">add_subdirectory</span><span class="p">(</span> <span \
class="s">sounds</span> <span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There&#39;s two sounds \
folders? One here and one in src? Maybe you can attach to the bug the files they \
contain so i can actually test this?</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;m not \
sure if it should have its own sound files. The open file dialog now goes to KDE \
default sound files folder. Should it point to its own sound directory (If I find the \
KDE_Glass_Break.ogg)? But, yes, in any case, one (or zero) sound directory is enough.
By the way, I do not have the KDE_Glass_Break.ogg file in KDE4 sources (including \
kdeartwork). Will search at home. Was it a KDE 3 file?</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 17th, 2014, 10:49 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/115758/diff/4/?file=244622#file244622line44" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kgeography.kcfg</a>  <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="tb">	</span>    \
&lt;default&gt;false&lt;/default&gt;</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you think it makes \
sense this to be enabled by default? I am not sure</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;m not \
sure also, but the bug report say it should be enabled by default. So I&#39;ll change \
it.</pre> <br />

<p>- Jaime Torres</p>

<br />
<p>On February 17th, 2014, 7:47 p.m. UTC, Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated Feb. 17, 2014, 7:47 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=132702">132702</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The code to choose the sound file is borrowed from kalarm. Add phonon to \
play sounds (can not be easier). Add the configuration to select the sound \
files.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It only make sounds when selected in the configuration, and the sound \
file exists.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(e7a6d9c)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(9e49f0d)</span></li>

 <li>src/askwidget.h <span style="color: grey">(32421b0)</span></li>

 <li>src/askwidget.cpp <span style="color: grey">(7f9e3cc)</span></li>

 <li>src/boxasker.h <span style="color: grey">(507099f)</span></li>

 <li>src/boxasker.cpp <span style="color: grey">(f0a5b60)</span></li>

 <li>src/capitaldivisionasker.h <span style="color: grey">(744c43c)</span></li>

 <li>src/capitaldivisionasker.cpp <span style="color: grey">(495eb26)</span></li>

 <li>src/divisioncapitalasker.h <span style="color: grey">(0246482)</span></li>

 <li>src/divisioncapitalasker.cpp <span style="color: grey">(625379b)</span></li>

 <li>src/divisionflagasker.h <span style="color: grey">(ffee8c2)</span></li>

 <li>src/divisionflagasker.cpp <span style="color: grey">(361c973)</span></li>

 <li>src/flagdivisionasker.h <span style="color: grey">(623a249)</span></li>

 <li>src/flagdivisionasker.cpp <span style="color: grey">(34f7711)</span></li>

 <li>src/kgeography.h <span style="color: grey">(4506bd0)</span></li>

 <li>src/kgeography.cpp <span style="color: grey">(e5e5305)</span></li>

 <li>src/kgeography.kcfg <span style="color: grey">(14f5d4f)</span></li>

 <li>src/kgeographyoptions.ui <span style="color: grey">(109b077)</span></li>

 <li>src/mapasker.h <span style="color: grey">(4e89fe5)</span></li>

 <li>src/mapasker.cpp <span style="color: grey">(22e0c24)</span></li>

 <li>src/placeasker.h <span style="color: grey">(7d27178)</span></li>

 <li>src/placeasker.cpp <span style="color: grey">(d65e030)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115758/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 