'Re: Review Request 112667: Add solar/lunar eclipse button to conjunction tool'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 112667: Add solar/lunar eclipse button to conjunction tool
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2014-01-16 16:01:22
Message-ID: 20140116160122.18276.29057 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 4:01 p.m.)

Review request for KDE Edu, KStars and Rafal Kulaga.

Changes
-------

Replaced int by enum for defining type of eclipse

Repository: kstars

Description
-------

Add solar/lunar eclipse button to conjunctions tool for better usability 

Diffs (updated)
-----

  kstars/tools/conjunctions.h 2e37651 
  kstars/tools/conjunctions.cpp 529f91d 
  kstars/tools/conjunctions.ui d4c5138 

Diff: https://git.reviewboard.kde.org/r/112667/diff/

Testing
-------

Tested , it predicts correct dates of eclipse but some eclipse may not get displayed

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/112667/">https://git.reviewboard.kde.org/r/112667/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, KStars and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Jan. 16, 2014, 4:01 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replaced int by enum for defining type of eclipse</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add solar/lunar eclipse button to conjunctions tool for better usability \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested , it predicts correct dates of eclipse but some eclipse may not \
get displayed</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/tools/conjunctions.h <span style="color: grey">(2e37651)</span></li>

 <li>kstars/tools/conjunctions.cpp <span style="color: grey">(529f91d)</span></li>

 <li>kstars/tools/conjunctions.ui <span style="color: grey">(d4c5138)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/112667/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 