[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 112667: Add solar/lunar eclipse button to conjunction tool
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-01-13 21:44:09
Message-ID: 20140113214409.30264.85571 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112667/#review47350
-----------------------------------------------------------
kstars/tools/conjunctions.cpp
<https://git.reviewboard.kde.org/r/112667/#comment33712>
There's no need to set to null a variable that will cease to exist in the next line
kstars/tools/conjunctions.cpp
<https://git.reviewboard.kde.org/r/112667/#comment33713>
typos here too
kstars/tools/conjunctions.ui
<https://git.reviewboard.kde.org/r/112667/#comment33711>
Ecllipse -> Eclipse (and same below)
- Albert Astals Cid
On Jan. 13, 2014, 9:59 a.m., Vijay Dhameliya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112667/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 9:59 a.m.)
>
>
> Review request for KDE Edu, KStars and Rafal Kulaga.
>
>
> Repository: kstars
>
>
> Description
> -------
>
> Add solar/lunar eclipse button to conjunctions tool for better usability
>
>
> Diffs
> -----
>
> kstars/tools/conjunctions.h 2e37651
> kstars/tools/conjunctions.cpp 529f91d
> kstars/tools/conjunctions.ui d4c5138
>
> Diff: https://git.reviewboard.kde.org/r/112667/diff/
>
>
> Testing
> -------
>
> Tested , it predicts correct dates of eclipse but some eclipse may not get displayed
>
>
> Thanks,
>
> Vijay Dhameliya
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112667/">https://git.reviewboard.kde.org/r/112667/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/112667/diff/2/?file=233907#file233907line407" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">407</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">ObjectMoon</span> <span class="o">=</span> <span \
class="nb">NULL</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's \
no need to set to null a variable that will cease to exist in the next line</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/112667/diff/2/?file=233907#file233907line425" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ConjunctionsTool::showProgress(int n) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">425</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">typeItem</span> <span class="o">=</span> <span class="k">new</span> \
<span class="n">QStandardItem</span><span class="p">(</span> <span \
class="n">i18n</span><span class="p">(</span> <span class="s">"Solar \
Ecllipse"</span> <span class="p">)</span> <span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">typos here \
too</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/112667/diff/2/?file=233908#file233908line191" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kstars/tools/conjunctions.ui</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">191</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<string>Solar Ecllipse</string></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ecllipse \
-> Eclipse (and same below)</pre> </div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On January 13th, 2014, 9:59 a.m. UTC, Vijay Dhameliya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, KStars and Rafal Kulaga.</div>
<div>By Vijay Dhameliya.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2014, 9:59 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add solar/lunar eclipse button to conjunctions tool for better usability \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested , it predicts correct dates of eclipse but some eclipse may not \
get displayed</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/tools/conjunctions.h <span style="color: grey">(2e37651)</span></li>
<li>kstars/tools/conjunctions.cpp <span style="color: grey">(529f91d)</span></li>
<li>kstars/tools/conjunctions.ui <span style="color: grey">(d4c5138)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112667/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic