[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 114581: First step to port to KF5
From: "David Gil Oliva" <davidgiloliva () gmail ! com>
Date: 2014-01-07 6:03:37
Message-ID: 20140107060337.7621.59489 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114581/
-----------------------------------------------------------
(Updated Jan. 7, 2014, 6:03 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Albert Astals Cid and Aleix Pol Gonzalez.
Repository: kgeography
Description
-------
First step to port to KF5
It builds and it works fairly well. But:
--There still are some KDE4 classes to port away from.
--Some toolbar buttons don't show up.
Diffs
-----
CMakeLists.txt e7a6d9cbaa66871793854d2e6b17a3f7ce837324
doc/CMakeLists.txt 9752e88cd95133006dbf44ef039eb9ee08111e56
src/CMakeLists.txt 9e49f0d673d8fcc9df3c4ecc3f4ff5c88d0b307a
src/answersdialog.cpp b64c07ac76ee80994fa458eae0e507cad0234494
src/askwidget.cpp 7f9e3cc5fd08aa5869d0545cb09cb4310dea0f2d
src/boxasker.h 507099f5fe0842caa7653af6c49e961f023dc150
src/boxasker.cpp f0a5b608db1d23492f9175256f448f125b1ce57c
src/capitaldivisionasker.cpp 495eb26f813c5a69e07d7703a0cbefaa8b5cbb7a
src/divisioncapitalasker.cpp 625379b6022a03a610aa8819fabaf6230d9c5982
src/divisionflagasker.cpp 361c97396372cd5a1a0668803bd190615fdb338f
src/flagdivisionasker.cpp 34f7711b8e02061a3224dfd4f2a45601afc6e019
src/integerinputdialog.h bef021de21612d031a7d372e52a41a731a0e97cf
src/integerinputdialog.cpp c2243dc9a3fb9aa2e2f02cb1ecf3d8d3cc3b049a
src/kgeography.h 4506bd0c09f13ce39f79735091ac375353842136
src/kgeography.cpp e5e53050f5b70d8f467061d0bf2bce0e36f32691
src/kgeographyoptions.ui 109b0778642f1d92fd84909b709efed7c83e5b14
src/main.cpp 99273ff29a846aa68a105fd7b95e9a85982c8e28
src/map.cpp e8f1e7f77895efe86d6d7620a0008f28e8845951
src/mapasker.cpp 22e0c246187cd0bbd6aac4895f4bda325e43a93a
src/mapchooser.cpp a795fe7b2b539db4f7cda104e03688f3d0de5ad2
src/mapparser.cpp 126d516a1c5178539a037dff58485e59b63eea03
src/mapwidget.cpp 77b653a0a20af091f1f577c46581f99f197ac163
src/mypopup.cpp 939c982a55fa858d71976f9808beac89a7aa1640
src/placeasker.cpp d65e0305191e3104b938deffa3802f6d3b6a6118
src/placemapwidget.cpp 00675839adf33cf6359ddcbc4958f53c3e3cedf9
Diff: https://git.reviewboard.kde.org/r/114581/diff/
Testing
-------
Thanks,
David Gil Oliva
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114581/">https://git.reviewboard.kde.org/r/114581/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Albert Astals Cid and Aleix Pol Gonzalez.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2014, 6:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First step to port to KF5
It builds and it works fairly well. But:
--There still are some KDE4 classes to port away from.
--Some toolbar buttons don't show up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(e7a6d9cbaa66871793854d2e6b17a3f7ce837324)</span></li>
<li>doc/CMakeLists.txt <span style="color: \
grey">(9752e88cd95133006dbf44ef039eb9ee08111e56)</span></li>
<li>src/CMakeLists.txt <span style="color: \
grey">(9e49f0d673d8fcc9df3c4ecc3f4ff5c88d0b307a)</span></li>
<li>src/answersdialog.cpp <span style="color: \
grey">(b64c07ac76ee80994fa458eae0e507cad0234494)</span></li>
<li>src/askwidget.cpp <span style="color: \
grey">(7f9e3cc5fd08aa5869d0545cb09cb4310dea0f2d)</span></li>
<li>src/boxasker.h <span style="color: \
grey">(507099f5fe0842caa7653af6c49e961f023dc150)</span></li>
<li>src/boxasker.cpp <span style="color: \
grey">(f0a5b608db1d23492f9175256f448f125b1ce57c)</span></li>
<li>src/capitaldivisionasker.cpp <span style="color: \
grey">(495eb26f813c5a69e07d7703a0cbefaa8b5cbb7a)</span></li>
<li>src/divisioncapitalasker.cpp <span style="color: \
grey">(625379b6022a03a610aa8819fabaf6230d9c5982)</span></li>
<li>src/divisionflagasker.cpp <span style="color: \
grey">(361c97396372cd5a1a0668803bd190615fdb338f)</span></li>
<li>src/flagdivisionasker.cpp <span style="color: \
grey">(34f7711b8e02061a3224dfd4f2a45601afc6e019)</span></li>
<li>src/integerinputdialog.h <span style="color: \
grey">(bef021de21612d031a7d372e52a41a731a0e97cf)</span></li>
<li>src/integerinputdialog.cpp <span style="color: \
grey">(c2243dc9a3fb9aa2e2f02cb1ecf3d8d3cc3b049a)</span></li>
<li>src/kgeography.h <span style="color: \
grey">(4506bd0c09f13ce39f79735091ac375353842136)</span></li>
<li>src/kgeography.cpp <span style="color: \
grey">(e5e53050f5b70d8f467061d0bf2bce0e36f32691)</span></li>
<li>src/kgeographyoptions.ui <span style="color: \
grey">(109b0778642f1d92fd84909b709efed7c83e5b14)</span></li>
<li>src/main.cpp <span style="color: \
grey">(99273ff29a846aa68a105fd7b95e9a85982c8e28)</span></li>
<li>src/map.cpp <span style="color: \
grey">(e8f1e7f77895efe86d6d7620a0008f28e8845951)</span></li>
<li>src/mapasker.cpp <span style="color: \
grey">(22e0c246187cd0bbd6aac4895f4bda325e43a93a)</span></li>
<li>src/mapchooser.cpp <span style="color: \
grey">(a795fe7b2b539db4f7cda104e03688f3d0de5ad2)</span></li>
<li>src/mapparser.cpp <span style="color: \
grey">(126d516a1c5178539a037dff58485e59b63eea03)</span></li>
<li>src/mapwidget.cpp <span style="color: \
grey">(77b653a0a20af091f1f577c46581f99f197ac163)</span></li>
<li>src/mypopup.cpp <span style="color: \
grey">(939c982a55fa858d71976f9808beac89a7aa1640)</span></li>
<li>src/placeasker.cpp <span style="color: \
grey">(d65e0305191e3104b938deffa3802f6d3b6a6118)</span></li>
<li>src/placemapwidget.cpp <span style="color: \
grey">(00675839adf33cf6359ddcbc4958f53c3e3cedf9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114581/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic