[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 114692: Better Plotter2D
From: Percy_Camilo_Triveño_Aucahuasi <percy.camilo.ta () gmail ! com>
Date: 2013-12-31 18:20:59
Message-ID: 20131231182059.1620.67427 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 30, 2013, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plotter2d.cpp, line 882
> > <https://git.reviewboard.kde.org/r/114692/diff/1/?file=227426#file227426line882>
> >
> > Why did you change that?
> >
at() can be faster than operator[](), because it never causes a deep copy to occur.
> On Dec. 30, 2013, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plotter2d.cpp, line 1154
> > <https://git.reviewboard.kde.org/r/114692/diff/1/?file=227426#file227426line1154>
> >
> > This changes behavior. Why?
The last one was buggy, if you see the description in the previous version it says: \
"FIXME:Bad solution" the one that I'm proposing is the standard behavior for zooming \
and I think is bug free.
> On Dec. 30, 2013, 12:45 a.m., Aleix Pol Gonzalez wrote:
> > analitzaplot/plottingenums.h, line 37
> > <https://git.reviewboard.kde.org/r/114692/diff/1/?file=227428#file227428line37>
> >
> > Unrelated changes, please don't commit those brace movements
ok
- Percy Camilo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114692/#review46424
-----------------------------------------------------------
On Dec. 28, 2013, 8:09 a.m., Percy Camilo Triveño Aucahuasi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114692/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2013, 8:09 a.m.)
>
>
> Review request for KDE Edu and Aleix Pol Gonzalez.
>
>
> Repository: analitza
>
>
> Description
> -------
>
> - Fix many bugs (ticks, labels, zooming, etc,)
> - Add polar angles and polar axis.
> - Add option to draw the angles in radians, degrees and gradians.
> - Add new grid styles (some similar to KmPlot like crosses)
> - Better API to manage colors and to set render options (like drawticks, etc.)
> - Many minor fixes/improvements too.
>
>
> Diffs
> -----
>
> analitzaplot/plottingenums.h f0c4c1c
> analitzaplot/private/utils/mathutils.h 08630b8
> analitzaplot/private/utils/mathutils.cpp d44ed6d
> analitzagui/plotsview2d.h b08a716
> analitzagui/plotsview2d.cpp f66f22d
> analitzaplot/plotitem.h efe942c
> analitzaplot/plotter2d.h ac52684
> analitzaplot/plotter2d.cpp 48085f1
> analitzaplot/plotter3d.h 85c3378
>
> Diff: https://git.reviewboard.kde.org/r/114692/diff/
>
>
> Testing
> -------
>
> All test pass, all analitzaplot demos run ok
>
>
> Thanks,
>
> Percy Camilo Triveño Aucahuasi
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114692/">https://git.reviewboard.kde.org/r/114692/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 30th, 2013, 12:45 a.m. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114692/diff/1/?file=227426#file227426line882" \
style="color: black; font-weight: bold; text-decoration: \
underline;">analitzaplot/plotter2d.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Plotter2D::drawFunctions(QPaintDevice *qpd)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">492</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QPointF</span> <span class="nf">ultim</span><span class="p">(</span><span \
class="n">toWidget</span><span class="p">(</span><span class="n">vect</span><span \
class="p"><span class="hl">[</span></span><span class="mi"><span \
class="hl">0</span></span><span class="p"><span \
class="hl">]</span>));</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">825</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">QPointF</span> <span \
class="nf">ultim</span><span class="p">(</span><span class="n">toWidget</span><span \
class="p">(</span><span class="n">vect</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span class="hl">at</span></span><span \
class="p"><span class="hl">(</span></span><span class="mi"><span \
class="hl">0</span></span><span class="p"><span \
class="hl">)</span>));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why did you change that? \
</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">at() can be \
faster than operator[](), because it never causes a deep copy to occur. </pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 30th, 2013, 12:45 a.m. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114692/diff/1/?file=227426#file227426line1154" \
style="color: black; font-weight: bold; text-decoration: \
underline;">analitzaplot/plotter2d.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Plotter2D::setXAxisLabel(const QString &label)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">745</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_ticksFormat</span> <span class="o">=</span> <span \
class="n">tsfmt</span><span class="p">;</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1091</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">scaleViewport</span><span class="p">(</span><span \
class="n">ZoomInFactor</span><span class="p">,</span> <span \
class="n">QPoint</span><span class="p">(</span><span class="n">m_size</span><span \
class="p">.</span><span class="n">width</span><span class="p">()</span><span \
class="o">*</span><span class="mf">0.5</span><span class="p">,</span> <span \
class="n">m_size</span><span class="p">.</span><span class="n">height</span><span \
class="p">()</span><span class="o">*</span><span class="mf">0.5</span><span \
class="p">),</span> <span class="n">repaint</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This changes behavior. \
Why?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The last \
one was buggy, if you see the description in the previous version it says: \
"FIXME:Bad solution" the one that I'm proposing is the standard \
behavior for zooming and I think is bug free. </pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 30th, 2013, 12:45 a.m. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114692/diff/1/?file=227428#file227428line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">analitzaplot/plottingenums.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">enum \
CoordinateSystem {</pre></td> <td colspan="2"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">35</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">enum</span> \
<span class="n">CoordinateSystem</span><span class="hl"> </span><span class="p"><span \
class="hl">{</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">37</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="k">enum</span> <span \
class="n">CoordinateSystem</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unrelated changes, \
please don't commit those brace movements</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok</pre> \
<br />
<p>- Percy Camilo</p>
<br />
<p>On December 28th, 2013, 8:09 a.m. UTC, Percy Camilo Triveño Aucahuasi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Aleix Pol Gonzalez.</div>
<div>By Percy Camilo Triveño Aucahuasi.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 8:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
analitza
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Fix many bugs (ticks, labels, zooming, etc,)
- Add polar angles and polar axis.
- Add option to draw the angles in radians, degrees and gradians.
- Add new grid styles (some similar to KmPlot like crosses)
- Better API to manage colors and to set render options (like drawticks, etc.)
- Many minor fixes/improvements too.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All test pass, all analitzaplot demos run ok</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>analitzaplot/plottingenums.h <span style="color: grey">(f0c4c1c)</span></li>
<li>analitzaplot/private/utils/mathutils.h <span style="color: \
grey">(08630b8)</span></li>
<li>analitzaplot/private/utils/mathutils.cpp <span style="color: \
grey">(d44ed6d)</span></li>
<li>analitzagui/plotsview2d.h <span style="color: grey">(b08a716)</span></li>
<li>analitzagui/plotsview2d.cpp <span style="color: grey">(f66f22d)</span></li>
<li>analitzaplot/plotitem.h <span style="color: grey">(efe942c)</span></li>
<li>analitzaplot/plotter2d.h <span style="color: grey">(ac52684)</span></li>
<li>analitzaplot/plotter2d.cpp <span style="color: grey">(48085f1)</span></li>
<li>analitzaplot/plotter3d.h <span style="color: grey">(85c3378)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114692/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic