[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 114745: [Kig] File Loading Based on MIME Types
From: "Commit Hook" <null () kde ! org>
Date: 2013-12-31 13:46:35
Message-ID: 20131231134635.1620.53956 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114745/#review46494
-----------------------------------------------------------
This review has been submitted with commit 985cbc9c1799b915b47692b17a110346754aea73 \
by David E. Narvaez to branch master.
- Commit Hook
On Dec. 31, 2013, 1:45 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114745/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2013, 1:45 p.m.)
>
>
> Review request for KDE Edu and David Faure.
>
>
> Repository: kig
>
>
> Description
> -------
>
> These are changes I worked months ago when I found and fixed bug 322578. Back then \
> I had a brief e-mail exchange with dfaure about this change and he thought it is \
> better to load files based on their MIME types instead of the file extensions. \
> Besides the fact that it loads the files based on their MIME types, these changes \
> also modernize the loading of the Kig part by using KService, and querying the \
> KService for the supported MIME types to load. There's a noticeable change in the \
> UI, see the attached picture.
>
> Diffs
> -----
>
> filters/filter.h 970da7b
> filters/filter.cc 8d5a676
> kig/kig.h fe56bfd
> kig/kig.cpp e426deb
> kig/kig_part.desktop 9c7139e
>
> Diff: https://git.reviewboard.kde.org/r/114745/diff/
>
>
> Testing
> -------
>
> Loaded all files in the example folder of the kig repository, all loading OK. It \
> lists exactly 8 files, same as my 4.12 installation of Kig.
>
> File Attachments
> ----------------
>
> No file extensions shown in the Open File dialog
> https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/87ba4f49-ab1e-411b-9491-422484d8f2a5__kignewfilters.png
>
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114745/">https://git.reviewboard.kde.org/r/114745/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 985cbc9c1799b915b47692b17a110346754aea73 by David E. Narvaez to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On December 31st, 2013, 1:45 p.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and David Faure.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2013, 1:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These are changes I worked months ago when I found and fixed bug 322578. \
Back then I had a brief e-mail exchange with dfaure about this change and he thought \
it is better to load files based on their MIME types instead of the file extensions. \
Besides the fact that it loads the files based on their MIME types, these changes \
also modernize the loading of the Kig part by using KService, and querying the \
KService for the supported MIME types to load. There's a noticeable change in the \
UI, see the attached picture.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loaded all files in the example folder of the kig repository, all \
loading OK. It lists exactly 8 files, same as my 4.12 installation of Kig.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/filter.h <span style="color: grey">(970da7b)</span></li>
<li>filters/filter.cc <span style="color: grey">(8d5a676)</span></li>
<li>kig/kig.h <span style="color: grey">(fe56bfd)</span></li>
<li>kig/kig.cpp <span style="color: grey">(e426deb)</span></li>
<li>kig/kig_part.desktop <span style="color: grey">(9c7139e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114745/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/87ba4f49-ab1e-411b-9491-422484d8f2a5__kignewfilters.png">No \
file extensions shown in the Open File dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic