'Re: Review Request 112496: Column for Object 2 is added in conjunctions tool and default width of co'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 112496: Column for Object 2 is added in conjunctions tool and default width of co
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-12-31 4:12:16
Message-ID: 20131231041216.12418.49022 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112496/
-----------------------------------------------------------

(Updated Dec. 31, 2013, 4:12 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.

Repository: kstars

Description
-------

In conjunctions tool default width of column in text box is set large enough to make \
it look better and column "object 2" is added to keep log of to which object the \
object 1 is mapping,  when we have calculated many conjunctions from same object 1 to \
different object 2s.

Diffs
-----

  kstars/kstarsinit.cpp a4393e6 
  kstars/tools/conjunctions.h b51209e 
  kstars/tools/conjunctions.cpp 39cef00 
  kstars/tools/conjunctions.ui 80374b1 

Diff: https://git.reviewboard.kde.org/r/112496/diff/

Testing
-------

tested

File Attachments
----------------

  https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png

  https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/112496/">https://git.reviewboard.kde.org/r/112496/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal \
Kulaga.</div> <div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Dec. 31, 2013, 4:12 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In conjunctions tool default width of column in text box is set large \
enough to make it look better and column &quot;object 2&quot; is added to keep log of \
to which object the object 1 is mapping,  when we have calculated many conjunctions \
from same object 1 to different object 2s.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/kstarsinit.cpp <span style="color: grey">(a4393e6)</span></li>

 <li>kstars/tools/conjunctions.h <span style="color: grey">(b51209e)</span></li>

 <li>kstars/tools/conjunctions.cpp <span style="color: grey">(39cef00)</span></li>

 <li>kstars/tools/conjunctions.ui <span style="color: grey">(80374b1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/112496/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_after.png">Conjunction_tool_after.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/09/03/Conjunction_tool_Before.png">Conjunction_tool_Before.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 