'Review Request 114745: [Kig] File Loading Based on MIME Types'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request 114745: [Kig] File Loading Based on MIME Types
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2013-12-31 2:48:01
Message-ID: 20131231024801.12418.21008 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114745/
-----------------------------------------------------------

Review request for KDE Edu and David Faure.

Repository: kig

Description
-------

These are changes I worked months ago when I found and fixed bug 322578. Back then I \
had a brief e-mail exchange with dfaure about this change and he thought it is better \
to load files based on their MIME types instead of the file extensions. Besides the \
fact that it loads the files  based on their MIME types, these changes also modernize \
the loading of the Kig part by using KService, and querying the KService for the \
supported MIME types to load. There's a noticeable change in the UI, see the attached \
picture.

Diffs
-----

  filters/filter.h 970da7b 
  filters/filter.cc 8d5a676 
  kig/kig.h fe56bfd 
  kig/kig.cpp e426deb 
  kig/kig_part.desktop 9c7139e 

Diff: https://git.reviewboard.kde.org/r/114745/diff/

Testing
-------

Loaded all files in the example folder of the kig repository, all loading OK. It \
lists exactly 8 files, same as my 4.12 installation of Kig.

Thanks,

David Narváez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114745/">https://git.reviewboard.kde.org/r/114745/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and David Faure.</div>
<div>By David Narváez.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These are changes I worked months ago when I found and fixed bug 322578. \
Back then I had a brief e-mail exchange with dfaure about this change and he thought \
it is better to load files based on their MIME types instead of the file extensions. \
Besides the fact that it loads the files  based on their MIME types, these changes \
also modernize the loading of the Kig part by using KService, and querying the \
KService for the supported MIME types to load. There&#39;s a noticeable change in the \
UI, see the attached picture.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loaded all files in the example folder of the kig repository, all \
loading OK. It lists exactly 8 files, same as my 4.12 installation of Kig.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>filters/filter.h <span style="color: grey">(970da7b)</span></li>

 <li>filters/filter.cc <span style="color: grey">(8d5a676)</span></li>

 <li>kig/kig.h <span style="color: grey">(fe56bfd)</span></li>

 <li>kig/kig.cpp <span style="color: grey">(e426deb)</span></li>

 <li>kig/kig_part.desktop <span style="color: grey">(9c7139e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114745/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 