Ship it!
In general it looks good to me, once this issues have been sorted out, you can commit. (But please, sort them out)
Seems like you want these methods virtual.
|
analitzaplot/plotter2d.cpp
(Diff revision 1)
|
void Plotter2D::drawFunctions(QPaintDevice *qpd) |
| 492 |
QPointF ultim(toWidget(vect[0])); |
825 |
QPointF ultim(toWidget(vect.at(0))); |
Why did you change that?
|
analitzaplot/plotter2d.cpp
(Diff revision 1)
|
void Plotter2D::setXAxisLabel(const QString &label) |
| 745 |
m_ticksFormat = tsfmt; |
1091 |
scaleViewport(ZoomInFactor, QPoint(m_size.width()*0.5, m_size.height()*0.5), repaint); |
This changes behavior. Why?
Unrelated changes, please don't commit those brace movements
- Aleix Pol Gonzalez
On December 28th, 2013, 8:09 a.m. UTC, Percy Camilo Triveño Aucahuasi wrote:
|
Review request for KDE Edu and Aleix Pol Gonzalez.
By Percy Camilo Triveño Aucahuasi.
Updated Dec. 28, 2013, 8:09 a.m.
Repository:
analitza
Description
- Fix many bugs (ticks, labels, zooming, etc,)
- Add polar angles and polar axis.
- Add option to draw the angles in radians, degrees and gradians.
- Add new grid styles (some similar to KmPlot like crosses)
- Better API to manage colors and to set render options (like drawticks, etc.)
- Many minor fixes/improvements too.
|
Testing
All test pass, all analitzaplot demos run ok
|
Diffs
- analitzaplot/plottingenums.h (f0c4c1c)
- analitzaplot/private/utils/mathutils.h (08630b8)
- analitzaplot/private/utils/mathutils.cpp (d44ed6d)
- analitzagui/plotsview2d.h (b08a716)
- analitzagui/plotsview2d.cpp (f66f22d)
- analitzaplot/plotitem.h (efe942c)
- analitzaplot/plotter2d.h (ac52684)
- analitzaplot/plotter2d.cpp (48085f1)
- analitzaplot/plotter3d.h (85c3378)
View Diff
|