From kde-edu-devel Mon Dec 30 00:45:21 2013 From: "Aleix Pol Gonzalez" Date: Mon, 30 Dec 2013 00:45:21 +0000 To: kde-edu-devel Subject: Re: Review Request 114692: Better Plotter2D Message-Id: <20131230004521.21905.18687 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=138836434530946 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1595115550413974502==" --===============1595115550413974502== Content-Type: multipart/alternative; boundary="===============4025112025154635602==" --===============4025112025154635602== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114692/#review46424 ----------------------------------------------------------- Ship it! In general it looks good to me, once this issues have been sorted out, you can commit. (But please, sort them out) analitzagui/plotsview2d.h Seems like you want these methods virtual. analitzaplot/plotter2d.cpp Why did you change that? analitzaplot/plotter2d.cpp This changes behavior. Why? analitzaplot/plottingenums.h Unrelated changes, please don't commit those brace movements - Aleix Pol Gonzalez On Dec. 28, 2013, 8:09 a.m., Percy Camilo Triveño Aucahuasi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114692/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2013, 8:09 a.m.) > > > Review request for KDE Edu and Aleix Pol Gonzalez. > > > Repository: analitza > > > Description > ------- > > - Fix many bugs (ticks, labels, zooming, etc,) > - Add polar angles and polar axis. > - Add option to draw the angles in radians, degrees and gradians. > - Add new grid styles (some similar to KmPlot like crosses) > - Better API to manage colors and to set render options (like drawticks, etc.) > - Many minor fixes/improvements too. > > > Diffs > ----- > > analitzaplot/plottingenums.h f0c4c1c > analitzaplot/private/utils/mathutils.h 08630b8 > analitzaplot/private/utils/mathutils.cpp d44ed6d > analitzagui/plotsview2d.h b08a716 > analitzagui/plotsview2d.cpp f66f22d > analitzaplot/plotitem.h efe942c > analitzaplot/plotter2d.h ac52684 > analitzaplot/plotter2d.cpp 48085f1 > analitzaplot/plotter3d.h 85c3378 > > Diff: https://git.reviewboard.kde.org/r/114692/diff/ > > > Testing > ------- > > All test pass, all analitzaplot demos run ok > > > Thanks, > > Percy Camilo Triveño Aucahuasi > > --===============4025112025154635602== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114692/

Ship it!

In general it looks good to me, once this issues have been sorted out, you can commit. (But please, sort them out)

analitzagui/plotsview2d.h (Diff revision 1)
public slots:
		116	void zoomIn() { Plotter2D::zoomIn(true); }

Seems like you want these methods virtual.

analitzaplot/plotter2d.cpp (Diff revision 1)
void Plotter2D::drawFunctions(QPaintDevice *qpd)
492	QPointF ultim(toWidget(vect[0]));	825	QPointF ultim(toWidget(vect.at(0)));

Why did you change that?

analitzaplot/plotter2d.cpp (Diff revision 1)
void Plotter2D::setXAxisLabel(const QString &label)
745	m_ticksFormat = tsfmt;	1091	scaleViewport(ZoomInFactor, QPoint(m_size.width()0.5, m_size.height()0.5), repaint);

This changes behavior. Why?

analitzaplot/plottingenums.h (Diff revision 1)
enum CoordinateSystem {
35	enum CoordinateSystem {	37	enum CoordinateSystem

Unrelated changes, please don't commit those brace movements

- Aleix Pol Gonzalez

On December 28th, 2013, 8:09 a.m. UTC, Percy Camilo Triveño Aucahuasi wrote:

Review request for KDE Edu and Aleix Pol Gonzalez.

By Percy Camilo Triveño Aucahuasi.

Updated Dec. 28, 2013, 8:09 a.m.

Repository: analitza

Description

- Fix many bugs (ticks, labels, zooming, etc,)
- Add polar angles and polar axis.
- Add option to draw the angles in radians, degrees and gradians.
- Add new grid styles (some similar to KmPlot like crosses)
- Better API to manage colors and to set render options (like drawticks, etc.)
- Many minor fixes/improvements too.

Testing

All test pass, all analitzaplot demos run ok

Diffs

analitzaplot/plottingenums.h (f0c4c1c)
analitzaplot/private/utils/mathutils.h (08630b8)
analitzaplot/private/utils/mathutils.cpp (d44ed6d)
analitzagui/plotsview2d.h (b08a716)
analitzagui/plotsview2d.cpp (f66f22d)
analitzaplot/plotitem.h (efe942c)
analitzaplot/plotter2d.h (ac52684)
analitzaplot/plotter2d.cpp (48085f1)
analitzaplot/plotter3d.h (85c3378)

--===============4025112025154635602==-- --===============1595115550413974502== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============1595115550413974502==--