'Re: Review Request 114006: Update min and max value at the same time in order to be more friendly wi'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 114006: Update min and max value at the same time in order to be more friendly wi
From:       "Yichao Yu" <yyc1992 () gmail ! com>
Date:       2013-12-28 17:23:22
Message-ID: 20131228172322.18800.76370 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114006/
-----------------------------------------------------------

(Updated Dec. 28, 2013, 5:23 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Laurent Montel and Jeremy Whiting.

Repository: kalzium

Description
-------

This patch makes the behavior while typing in the min/max boxes more friendly.

Currently if one types in the maximum value box, the minimum value will stuck at a \
small value due to the small value in the maximum value box before one finish typing. \
(I don't really call this a bug, but I think it is not friendly.)

This patch tries to update both the maximum and minimum values whenever one of them \
changes (in the right order to always respect the one that changes) so that the \
actual range displayed is always the closed possible to the input values. It also \
covers the cases when min/max values change from illegal values to legal values (max \
> min) in some other ways.

Diffs
-----

  src/spectrumviewimpl.h c596154 
  src/spectrumviewimpl.cpp 0327202 
  src/spectrumwidget.h 5117d26 

Diff: https://git.reviewboard.kde.org/r/114006/diff/

Testing
-------

Compiles and fixes the problem.

Thanks,

Yichao Yu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114006/">https://git.reviewboard.kde.org/r/114006/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Laurent Montel and Jeremy Whiting.</div>
<div>By Yichao Yu.</div>

<p style="color: grey;"><i>Updated Dec. 28, 2013, 5:23 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes the behavior while typing in the min/max boxes more \
friendly.

Currently if one types in the maximum value box, the minimum value will stuck at a \
small value due to the small value in the maximum value box before one finish typing. \
(I don&#39;t really call this a bug, but I think it is not friendly.)

This patch tries to update both the maximum and minimum values whenever one of them \
changes (in the right order to always respect the one that changes) so that the \
actual range displayed is always the closed possible to the input values. It also \
covers the cases when min/max values change from illegal values to legal values (max \
&gt; min) in some other ways. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and fixes the problem.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/spectrumviewimpl.h <span style="color: grey">(c596154)</span></li>

 <li>src/spectrumviewimpl.cpp <span style="color: grey">(0327202)</span></li>

 <li>src/spectrumwidget.h <span style="color: grey">(5117d26)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114006/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 