'Re: Review Request 113817: Default Syntax Highlighting in Cantor Script Extension Widget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 113817: Default Syntax Highlighting in Cantor Script Extension Widget
From:       "Filipe Saraiva" <filipe () kde ! org>
Date:       2013-11-14 0:35:30
Message-ID: 20131114003530.21273.61962 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113817/
-----------------------------------------------------------

(Updated Nov. 14, 2013, 12:35 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Alexander Rieder.

Repository: cantor

Description
-------

In currently Cantor version, the user must choose the syntax highlighting changing \
the option in a kpart menu - it is hide from user. This patch allow syntax \
highlighting in script extension when the script widget is launched by user.

I ported Octave, Sage, R, and Maxima backends to support it too.

Diffs
-----

  src/backends/octave/octaveextensions.cpp 534e69e 
  src/backends/sage/sageextensions.h 5022c69 
  src/backends/sage/sageextensions.cpp 9efc856 
  src/cantor_part.cpp 7aad304 
  src/lib/extension.h 3c5085d 
  src/scripteditorwidget.h 2ca672d 
  src/scripteditorwidget.cpp 03684aa 
  src/backends/R/rextensions.h 39d5f1b 
  src/backends/R/rextensions.cpp a036220 
  src/backends/maxima/maximaextensions.h 34afc2a 
  src/backends/maxima/maximaextensions.cpp 211c8cb 
  src/backends/octave/octaveextensions.h 5dae826 

Diff: http://git.reviewboard.kde.org/r/113817/diff/

Testing
-------

Tested with Octave, Sage, R, and Maxima backends.

Thanks,

Filipe Saraiva

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113817/">http://git.reviewboard.kde.org/r/113817/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Alexander Rieder.</div>
<div>By Filipe Saraiva.</div>

<p style="color: grey;"><i>Updated Nov. 14, 2013, 12:35 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In currently Cantor version, the user must choose the syntax \
highlighting changing the option in a kpart menu - it is hide from user. This patch \
allow syntax highlighting in script extension when the script widget is launched by \
user.

I ported Octave, Sage, R, and Maxima backends to support it too.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with Octave, Sage, R, and Maxima backends.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/octave/octaveextensions.cpp <span style="color: \
grey">(534e69e)</span></li>

 <li>src/backends/sage/sageextensions.h <span style="color: \
grey">(5022c69)</span></li>

 <li>src/backends/sage/sageextensions.cpp <span style="color: \
grey">(9efc856)</span></li>

 <li>src/cantor_part.cpp <span style="color: grey">(7aad304)</span></li>

 <li>src/lib/extension.h <span style="color: grey">(3c5085d)</span></li>

 <li>src/scripteditorwidget.h <span style="color: grey">(2ca672d)</span></li>

 <li>src/scripteditorwidget.cpp <span style="color: grey">(03684aa)</span></li>

 <li>src/backends/R/rextensions.h <span style="color: grey">(39d5f1b)</span></li>

 <li>src/backends/R/rextensions.cpp <span style="color: grey">(a036220)</span></li>

 <li>src/backends/maxima/maximaextensions.h <span style="color: \
grey">(34afc2a)</span></li>

 <li>src/backends/maxima/maximaextensions.cpp <span style="color: \
grey">(211c8cb)</span></li>

 <li>src/backends/octave/octaveextensions.h <span style="color: \
grey">(5dae826)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113817/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 