[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 113425: the map and divisions are added to the scene handled by the graphicsview.
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-11-11 22:00:35
Message-ID: 20131111220035.26990.8609 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113425/#review43472
-----------------------------------------------------------

Ship it!


Looks good. The question now is, where do we commit this one. It is a "big-ish" \
change, so one would think master, but on the other hand it fixes a bug some people \
is having so someone else would say KDE/4.11. 

I'm a bit undecided so i'd go for the middle way and go KDE/4.12.

What's your opinion?

- Albert Astals Cid


On Nov. 10, 2013, 11:41 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113425/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 11:41 a.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 285330
> http://bugs.kde.org/show_bug.cgi?id=285330
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Using addPixmap to a QGraphicsView, just let the view handle the zoom, moves.... \
> Just handling all the view events to move the division smoothly. This time, just \
> paint the background white and then draw the map without divisions (before the \
> first division is asked), then add the divisions as they are asked. (as always, the \
> red spaces will be gone). The variable "punto" will be translated. 
> 
> Diffs
> -----
> 
> src/placeasker.h 14dce46 
> src/placeasker.cpp dd2f02c 
> src/placemapwidget.h 6905a14 
> src/placemapwidget.cpp 94a4460 
> 
> Diff: http://git.reviewboard.kde.org/r/113425/diff/
> 
> 
> Testing
> -------
> 
> Zoom, move (it behaves like before), with several maps in two computers (one that \
> was not affected by the bug and one that was affected). 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113425/">http://git.reviewboard.kde.org/r/113425/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. The question \
now is, where do we commit this one. It is a &quot;big-ish&quot; change, so one would \
think master, but on the other hand it fixes a bug some people is having so someone \
else would say KDE/4.11. 

I&#39;m a bit undecided so i&#39;d go for the middle way and go KDE/4.12.

What&#39;s your opinion?</pre>
 <br />









<p>- Albert Astals Cid</p>


<br />
<p>On November 10th, 2013, 11:41 a.m. UTC, Jaime Torres Amate wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>


<p style="color: grey;"><i>Updated Nov. 10, 2013, 11:41 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=285330">285330</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using addPixmap to a QGraphicsView, just let the view handle the zoom, \
moves.... Just handling all the view events to move the division smoothly. This time, \
just paint the background white and then draw the map without divisions (before the \
first division is asked), then add the divisions as they are asked. (as always, the \
red spaces will be gone). The variable &quot;punto&quot; will be translated.</pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Zoom, move (it behaves like before), with several maps in two computers \
(one that was not affected by the bug and one that was affected). </pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/placeasker.h <span style="color: grey">(14dce46)</span></li>

 <li>src/placeasker.cpp <span style="color: grey">(dd2f02c)</span></li>

 <li>src/placemapwidget.h <span style="color: grey">(6905a14)</span></li>

 <li>src/placemapwidget.cpp <span style="color: grey">(94a4460)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113425/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic