[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 113660: filter the list of maps
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2013-11-11 17:19:04
Message-ID: 20131111171904.14303.98875 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113660/
-----------------------------------------------------------
(Updated Nov. 11, 2013, 5:19 p.m.)
Review request for KDE Edu and Albert Astals Cid.
Changes
-------
Argh... the inertia.. line does not need to be a member variable.
Bugs: 319974
http://bugs.kde.org/show_bug.cgi?id=319974
Repository: kgeography
Description
-------
Change from QListWidget to QListView because QListWidget setModel() is private :-(
Implemented an eventFilter to make QListView behave like a QListWidget.
Implemented a filterProxyModel to filter the list (by the first letters).
Is the text inside the KLineEdit right?
Should it filter by first letters or any letter?
Diffs (updated)
-----
src/mapchooser.cpp c2bf8ec
Diff: http://git.reviewboard.kde.org/r/113660/diff/
Testing
-------
Thanks,
Jaime Torres Amate
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113660/">http://git.reviewboard.kde.org/r/113660/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2013, 5:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Argh... the inertia.. \
line does not need to be a member variable.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319974">319974</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change from \
QListWidget to QListView because QListWidget setModel() is private :-( Implemented an \
eventFilter to make QListView behave like a QListWidget. Implemented a filterProxyModel to \
filter the list (by the first letters).
Is the text inside the KLineEdit right?
Should it filter by first letters or any letter?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mapchooser.cpp <span style="color: grey">(c2bf8ec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113660/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic