[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 113425: the map and divisions are added to the scene handled by the graphicsview.
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2013-10-31 18:45:17
Message-ID: 20131031184517.5939.32739 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 30, 2013, 11:10 p.m., Albert Astals Cid wrote:
> > Another graphical issue:
> > * Zoom in quite a bit
> > * Make sure your window is not maximized
> > * Press middle mouse button and don't release until it's outside of the window
> > * Release the middle mouse button
> > * See how the division you where supposed to put in the map is left there \
> > floating
> > * Sometimes when entering the window again the old one is cleaned but some other \
> > times you end up with two items (the ghost one is cleaned if you pass the new one \
> > over)
I can not reproduce in a vbox or with an ati card. (I guess you have an nvidia card).
Could you try using this code in placeMapWidget::placeMapWidget constructor?
setScene(p_scene);
p_scene->setItemIndexMethod(QGraphicsScene::NoIndex);
setViewportUpdateMode(QGraphicsView::FullViewportUpdate);
}
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113425/#review42725
-----------------------------------------------------------
On Oct. 28, 2013, 5:41 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113425/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 5:41 p.m.)
>
>
> Review request for KDE Edu and Albert Astals Cid.
>
>
> Bugs: 285330
> http://bugs.kde.org/show_bug.cgi?id=285330
>
>
> Repository: kgeography
>
>
> Description
> -------
>
> Using addPixmap to a QGraphicsView, just let the view handle the zoom, moves.... \
> Just handling all the view events to move the division smoothly. This time, just \
> paint the background white and then draw the map without divisions (before the \
> first division is asked), then add the divisions as they are asked. (as always, the \
> red spaces will be gone). The variable "punto" will be translated.
>
> Diffs
> -----
>
> src/placeasker.h 14dce46
> src/placeasker.cpp 07bea6c
> src/placemapwidget.h 6905a14
> src/placemapwidget.cpp 94a4460
>
> Diff: http://git.reviewboard.kde.org/r/113425/diff/
>
>
> Testing
> -------
>
> Zoom, move (it behaves like before), with several maps in two computers (one that \
> was not affected by the bug and one that was affected).
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113425/">http://git.reviewboard.kde.org/r/113425/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 30th, 2013, 11:10 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Another graphical issue:
* Zoom in quite a bit
* Make sure your window is not maximized
* Press middle mouse button and don't release until it's outside of the \
window
* Release the middle mouse button
* See how the division you where supposed to put in the map is left there floating
* Sometimes when entering the window again the old one is cleaned but some other \
times you end up with two items (the ghost one is cleaned if you pass the new one \
over)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can not reproduce in a \
vbox or with an ati card. (I guess you have an nvidia card). Could you try using this \
code in placeMapWidget::placeMapWidget constructor?
setScene(p_scene);
p_scene->setItemIndexMethod(QGraphicsScene::NoIndex);
setViewportUpdateMode(QGraphicsView::FullViewportUpdate);
}
</pre>
<br />
<p>- Jaime Torres</p>
<br />
<p>On October 28th, 2013, 5:41 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 5:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=285330">285330</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using addPixmap to a QGraphicsView, just let the view handle the zoom, \
moves.... Just handling all the view events to move the division smoothly. This time, \
just paint the background white and then draw the map without divisions (before the \
first division is asked), then add the divisions as they are asked. (as always, the \
red spaces will be gone). The variable "punto" will be translated.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Zoom, move (it behaves like before), with several maps in two computers \
(one that was not affected by the bug and one that was affected). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/placeasker.h <span style="color: grey">(14dce46)</span></li>
<li>src/placeasker.cpp <span style="color: grey">(07bea6c)</span></li>
<li>src/placemapwidget.h <span style="color: grey">(6905a14)</span></li>
<li>src/placemapwidget.cpp <span style="color: grey">(94a4460)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113425/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic