[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 113474: Export practice results in parley
From: "Yuri Chornoivan" <yurchor () ukr ! net>
Date: 2013-10-31 12:24:49
Message-ID: 20131031122449.6973.50330 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 30, 2013, 10:55 p.m., Albert Astals Cid wrote:
> > There is one hour until 4.12 feature freeze, if anyone can review and commit it'd \
> > be great, otherwise it'll have to wait for 4.13
I do not think that this is a problem.
KDE/4.11 branch with 2 new strings (due to the committed previous patches) is newer \
than master now.
So the merge will add at least 2 new strings anyway and these less than 10 strings \
should not be a great problem (at least worth for a string freeze break request to \
the kde-i18n-doc).
- Yuri
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113474/#review42723
-----------------------------------------------------------
On Oct. 28, 2013, 6:53 p.m., José Millán Soto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113474/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 6:53 p.m.)
>
>
> Review request for KDE Edu, Andreas Cord-Landwehr and Frederik Gladhorn.
>
>
> Repository: parley
>
>
> Description
> -------
>
> This patch allows to store the results of a practice in a file.
> It uses QTextDocument for generate the file, ODT and html are supported.
>
>
> Diffs
> -----
>
> src/parleyactions.h 7ce750d
> src/parleyactions.cpp f22e69a
> src/practice/practicesummarycomponent.h 670cc7c
> src/practice/practicesummarycomponent.cpp f3cb340
> src/practice/practicesummaryui.rc c1ef536
> src/practice/practiceui.rc 96c4a06
> src/practice/testentrymanager.h 6f8962c
> src/practice/testentrymanager.cpp 00c78e4
>
> Diff: http://git.reviewboard.kde.org/r/113474/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> José Millán Soto
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113474/">http://git.reviewboard.kde.org/r/113474/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 30th, 2013, 10:55 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is one hour until 4.12 feature freeze, if anyone can review and \
commit it'd be great, otherwise it'll have to wait for 4.13</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not think that this \
is a problem.
KDE/4.11 branch with 2 new strings (due to the committed previous patches) is newer \
than master now.
So the merge will add at least 2 new strings anyway and these less than 10 strings \
should not be a great problem (at least worth for a string freeze break request to \
the kde-i18n-doc).</pre> <br />
<p>- Yuri</p>
<br />
<p>On October 28th, 2013, 6:53 p.m. UTC, José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Andreas Cord-Landwehr and Frederik Gladhorn.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 6:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch allows to store the results of a practice in a file. It uses \
QTextDocument for generate the file, ODT and html are supported.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/parleyactions.h <span style="color: grey">(7ce750d)</span></li>
<li>src/parleyactions.cpp <span style="color: grey">(f22e69a)</span></li>
<li>src/practice/practicesummarycomponent.h <span style="color: \
grey">(670cc7c)</span></li>
<li>src/practice/practicesummarycomponent.cpp <span style="color: \
grey">(f3cb340)</span></li>
<li>src/practice/practicesummaryui.rc <span style="color: \
grey">(c1ef536)</span></li>
<li>src/practice/practiceui.rc <span style="color: grey">(96c4a06)</span></li>
<li>src/practice/testentrymanager.h <span style="color: grey">(6f8962c)</span></li>
<li>src/practice/testentrymanager.cpp <span style="color: \
grey">(00c78e4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113474/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic