'Re: Review Request 113502: Fix for Bug 326722 - swapped title and error message'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 113502: Fix for Bug 326722 - swapped title and error message
From:       "Commit Hook" <null () kde ! org>
Date:       2013-10-30 15:48:36
Message-ID: 20131030154836.28636.78586 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113502/#review42709
-----------------------------------------------------------

This review has been submitted with commit 23e075bb42ef47de4400a6820f6b058653fab52c \
by Jeremy Whiting to branch KDE/4.11.

- Commit Hook

On Oct. 30, 2013, 3:48 p.m., Vincenzo Pii wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113502/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 3:48 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Related bug: https://bugs.kde.org/show_bug.cgi?id=326722
> Implementation: KMessageBox::error method arguments were misplaced, just swapped \
> them to get the correct behavior. 
> 
> Diffs
> -----
> 
> src/tools/moleculeview.cpp 930fb6a 
> 
> Diff: http://git.reviewboard.kde.org/r/113502/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vincenzo Pii
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113502/">http://git.reviewboard.kde.org/r/113502/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 23e075bb42ef47de4400a6820f6b058653fab52c by Jeremy Whiting to \
branch KDE/4.11.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On October 30th, 2013, 3:48 p.m. UTC, Vincenzo Pii wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Vincenzo Pii.</div>

<p style="color: grey;"><i>Updated Oct. 30, 2013, 3:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Related bug: https://bugs.kde.org/show_bug.cgi?id=326722
Implementation: KMessageBox::error method arguments were misplaced, just swapped them \
to get the correct behavior.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/tools/moleculeview.cpp <span style="color: grey">(930fb6a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113502/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 