[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 113425: the map and divisions are added to the scene handled by the graphicsview.
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2013-10-29 19:21:08
Message-ID: 20131029192108.16797.13879 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 28, 2013, 11:21 p.m., Albert Astals Cid wrote:
> > src/placeasker.cpp, line 109
> > <http://git.reviewboard.kde.org/r/113425/diff/3-4/?file=205881#file205881line109>
> >
> > Why this change?
>
> Jaime Torres Amate wrote:
> I changed the way to calculate the distance from using the middle point of the \
> division rect and the mouse click to the top left division rect and top left image \
> click. Why? Because looking at the points reported when clicking a zoomed map, the \
> distance (even clicking in the right place) where >20. When I changed to the top \
> left image position and top left position, they matched. The problem is that the \
> image size is (-1,-1) smaller than the division rect, therefore the centers where \
> distancting as I zoomed the map. This problem is not present with the top left \
> corners.
> Albert Astals Cid wrote:
> Is this something related to this merge request? Or is it a different bug/issue?
It is related to this merge request. Without it, everybody will fail a lot \
positioning a zoomed map. (I mean, did not happen before).
- Jaime Torres
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113425/#review42564
-----------------------------------------------------------
On Oct. 28, 2013, 5:41 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113425/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 5:41 p.m.)
>
>
> Review request for KDE Edu and Albert Astals Cid.
>
>
> Bugs: 285330
> http://bugs.kde.org/show_bug.cgi?id=285330
>
>
> Repository: kgeography
>
>
> Description
> -------
>
> Using addPixmap to a QGraphicsView, just let the view handle the zoom, moves.... \
> Just handling all the view events to move the division smoothly. This time, just \
> paint the background white and then draw the map without divisions (before the \
> first division is asked), then add the divisions as they are asked. (as always, the \
> red spaces will be gone). The variable "punto" will be translated.
>
> Diffs
> -----
>
> src/placeasker.h 14dce46
> src/placeasker.cpp 07bea6c
> src/placemapwidget.h 6905a14
> src/placemapwidget.cpp 94a4460
>
> Diff: http://git.reviewboard.kde.org/r/113425/diff/
>
>
> Testing
> -------
>
> Zoom, move (it behaves like before), with several maps in two computers (one that \
> was not affected by the bug and one that was affected).
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113425/">http://git.reviewboard.kde.org/r/113425/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 28th, 2013, 11:21 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113425/diff/3-4/?file=205881#file205881line109" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/placeasker.cpp</a> <span style="font-weight: normal;">
(Diff revisions 3 - 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
placeAsker::handleMapClick(QRgb c, const QPoint & , const QPointF \
&mapPoint)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">108</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="tb"> </span><span class="kt">double</span> <span class="n">distX</span> <span \
class="o">=</span> <span class="n">p_currentDivisionRect</span><span \
class="p">.</span><span class="n"><span class="hl">center</span></span><span \
class="p"><span class="hl">().</span></span><span class="n">x</span><span \
class="p">()</span> <span class="o">-</span> <span class="n">mapPoint</span><span \
class="p">.</span><span class="n">x</span><span class="p">();</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">109</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="kt">double</span> <span \
class="n">distX</span> <span class="o">=</span> <span \
class="n">p_currentDivisionRect</span><span class="p">.</span><span \
class="n">x</span><span class="p">()</span> <span class="o">-</span> <span \
class="n">mapPoint</span><span class="p">.</span><span class="n">x</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why this change?</pre> \
</blockquote>
<p>On October 29th, 2013, 8 a.m. UTC, <b>Jaime Torres Amate</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I changed the way to \
calculate the distance from using the middle point of the division rect and the mouse \
click to the top left division rect and top left image click. Why? Because looking at \
the points reported when clicking a zoomed map, the distance (even clicking in the \
right place) where >20. When I changed to the top left image position and top left \
position, they matched. The problem is that the image size is (-1,-1) smaller than \
the division rect, therefore the centers where distancting as I zoomed the map. This \
problem is not present with the top left corners.</pre> </blockquote>
<p>On October 29th, 2013, 6:44 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this something \
related to this merge request? Or is it a different bug/issue?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is \
related to this merge request. Without it, everybody will fail a lot positioning a \
zoomed map. (I mean, did not happen before).</pre> <br />
<p>- Jaime Torres</p>
<br />
<p>On October 28th, 2013, 5:41 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 5:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=285330">285330</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using addPixmap to a QGraphicsView, just let the view handle the zoom, \
moves.... Just handling all the view events to move the division smoothly. This time, \
just paint the background white and then draw the map without divisions (before the \
first division is asked), then add the divisions as they are asked. (as always, the \
red spaces will be gone). The variable "punto" will be translated.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Zoom, move (it behaves like before), with several maps in two computers \
(one that was not affected by the bug and one that was affected). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/placeasker.h <span style="color: grey">(14dce46)</span></li>
<li>src/placeasker.cpp <span style="color: grey">(07bea6c)</span></li>
<li>src/placemapwidget.h <span style="color: grey">(6905a14)</span></li>
<li>src/placemapwidget.cpp <span style="color: grey">(94a4460)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113425/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic