[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 113484: Don't crash when downloading .tar.7z files with KNS
From: José_Manuel__Santamaría_Lema <panfaust () gmail ! com>
Date: 2013-10-29 10:10:40
Message-ID: 20131029101040.17960.72153 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113484/
-----------------------------------------------------------
(Updated Oct. 29, 2013, 10:10 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Repository: parley
Description
-------
Hello,
I got crash when I tried to download and install *.tar.7z file from KNS, specifically \
this one: http://opendesktop.org/content/show.php?content=124830
If I just download it manually, uncompress the *.tar.7z file and feed the kvtml file \
into parley it doesn't crash.
There are 2 separate problems involved here:
1) KNS doesn't work with *.tar.7z files.
2) Even if the the file format of the file downloaded from KNS isn't recognized for \
now, parley shouldn't crash.
The patch in this reviewboard is intended to fix the problem 2) and it was made with \
help from Aleix Pol (thanks!).
Just in case you are curious about the problem 1) - the related code from kdelibs is \
the following:
* knewstuff/knewstuff3/core/installation.cpp - function \
Installation::installDownloadedFileAndUncompress Here knewstuff tries to use KTar to \
deal with the downloaded file.
* files under kdecore/compression/*
Here is kfilterdev, if I'm not mistaken this is what KTar uses to deal with files \
compressed gz,bzip,etc. The thing is: there is no filter for *.7z files, so that's \
why they can't work in KNS right now.
Diffs
-----
src/parleydocument.cpp ceb5db2
Diff: http://git.reviewboard.kde.org/r/113484/diff/
Testing
-------
I have opened various local files and some others from GHNS, it seems the patch works \
for me.
Thanks,
José Manuel Santamaría Lema
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113484/">http://git.reviewboard.kde.org/r/113484/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By José Manuel Santamaría Lema.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2013, 10:10 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
I got crash when I tried to download and install *.tar.7z file from KNS, specifically \
this one: http://opendesktop.org/content/show.php?content=124830
If I just download it manually, uncompress the *.tar.7z file and feed the kvtml file \
into parley it doesn't crash.
There are 2 separate problems involved here:
1) KNS doesn't work with *.tar.7z files.
2) Even if the the file format of the file downloaded from KNS isn't recognized \
for now, parley shouldn't crash.
The patch in this reviewboard is intended to fix the problem 2) and it was made with \
help from Aleix Pol (thanks!).
Just in case you are curious about the problem 1) - the related code from kdelibs is \
the following:
* knewstuff/knewstuff3/core/installation.cpp - function \
Installation::installDownloadedFileAndUncompress Here knewstuff tries to use KTar to \
deal with the downloaded file.
* files under kdecore/compression/*
Here is kfilterdev, if I'm not mistaken this is what KTar uses to deal with files \
compressed gz,bzip,etc. The thing is: there is no filter for *.7z files, so \
that's why they can't work in KNS right now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have opened various local files and some others from GHNS, it seems \
the patch works for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/parleydocument.cpp <span style="color: grey">(ceb5db2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113484/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic