'Re: Review Request 112879: Restring addition of null supernovae objects to supernovaecomponent list'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 112879: Restring addition of null supernovae objects to supernovaecomponent list
From:       "Vijay Dhameliya" <vijay.atwork13 () gmail ! com>
Date:       2013-10-18 13:47:23
Message-ID: 20131018134723.24584.48217 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112879/
-----------------------------------------------------------

(Updated Oct. 18, 2013, 1:47 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal Kulaga.

Bugs: 322848
    http://bugs.kde.org/show_bug.cgi?id=322848

Repository: kstars

Description
-------

While loading data for supernovae, there seems error in reading file supernovae.dat  \
so it leads to creation of dummy supernovae object which leads to various error \
during run time of Kstars. So lets avoid creation of such dummy supernovae objects.  \
This fixes attached bug too.

Diffs
-----

  kstars/skycomponents/supernovaecomponent.cpp 166a3d5 

Diff: http://git.reviewboard.kde.org/r/112879/diff/

Testing
-------

Tested - Runs well
Bug resolved permanently 

Thanks,

Vijay Dhameliya

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112879/">http://git.reviewboard.kde.org/r/112879/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal \
Kulaga.</div> <div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Oct. 18, 2013, 1:47 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=322848">322848</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While loading data for supernovae, there seems error in reading file \
supernovae.dat  so it leads to creation of dummy supernovae object which leads to \
various error during run time of Kstars. So lets avoid creation of such dummy \
supernovae objects.  This fixes attached bug too.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested - Runs well Bug resolved permanently </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: \
grey">(166a3d5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112879/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 