'Re: Review Request 112726: Ordered visibility check for first point of SkyPolyLine in drawSkyPolylin'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 112726: Ordered visibility check for first point of SkyPolyLine in drawSkyPolylin
From:       "Henry de Valence" <hdevalence () gmail ! com>
Date:       2013-09-29 22:21:04
Message-ID: 20130929222104.3180.32007 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112726/#review41012
-----------------------------------------------------------

Ship it!

This looks OK to me.

- Henry de Valence

On Sept. 29, 2013, 6:27 a.m., Vijay Dhameliya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112726/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 6:27 a.m.)
> 
> 
> Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal \
> Kulaga. 
> 
> Bugs: 303547
> http://bugs.kde.org/show_bug.cgi?id=303547
> 
> 
> Repository: kstars
> 
> 
> Description
> -------
> 
> Variable isVisibleLast and isVisible are not initialized so stores random value \
> while operated and with check visibility and correct visibility of point are stored \
> in same variable when passed to toScreen function.   
> 
> Diffs
> -----
> 
> kstars/skyqpainter.cpp b53b76c 
> 
> Diff: http://git.reviewboard.kde.org/r/112726/diff/
> 
> 
> Testing
> -------
> 
> Tested 
> Lines on display appears correctly 
> 
> 
> Thanks,
> 
> Vijay Dhameliya
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112726/">http://git.reviewboard.kde.org/r/112726/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks OK to \
me.</pre>  <br />

<p>- Henry de Valence</p>

<br />
<p>On September 29th, 2013, 6:27 a.m. UTC, Vijay Dhameliya wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, KStars, Akarsh Simha, Henry de Valence, and Rafal \
Kulaga.</div> <div>By Vijay Dhameliya.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2013, 6:27 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=303547">303547</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kstars
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Variable isVisibleLast and isVisible are not initialized so stores \
random value while operated and with check visibility and correct visibility of point \
are stored in same variable when passed to toScreen function.  </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested  Lines on display appears correctly </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstars/skyqpainter.cpp <span style="color: grey">(b53b76c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112726/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 