From kde-edu-devel Sun Aug 25 16:58:26 2013 From: "Yuri Chornoivan" Date: Sun, 25 Aug 2013 16:58:26 +0000 To: kde-edu-devel Subject: Re: Review Request 112146: Make Parley scripts translatable using Kross Message-Id: <20130825165826.20033.20312 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=137744992917875 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7026225397393920658==" --===============7026225397393920658== Content-Type: multipart/alternative; boundary="===============4778454208660289703==" --===============4778454208660289703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112146/ ----------------------------------------------------------- (Updated Aug. 25, 2013, 4:58 p.m.) Status ------ This change has been discarded. Review request for KDE Edu and Frederik Gladhorn. Description ------- "Fetch Sound" and example scripts are not untranslatable, "Google Images" needs some not very elegant solution to not crash on non-ASCII locales. The patch against git/master tries to resolve these issues. Diffs ----- plugins/example.py d2ea5ed plugins/google_images.py 5317ba6 plugins/wiktionary/wiktionary_sound.py 1e03b02 Diff: http://git.reviewboard.kde.org/r/112146/diff/ Testing ------- Tested with Ukrainian translation (extraction, translation). Seems everything works without crashes and with "Scripts" menu items translated. Thanks, Yuri Chornoivan --===============4778454208660289703== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112146/

This change has been discarded.

Review request for KDE Edu and Frederik Gladhorn.

By Yuri Chornoivan.

Updated Aug. 25, 2013, 4:58 p.m.

Description

"Fetch Sound" and example scripts are not untranslatable, "Google Images" needs some not very elegant solution to not crash on non-ASCII locales.

The patch against git/master tries to resolve these issues.

Testing

Tested with Ukrainian translation (extraction, translation). Seems everything works without crashes and with "Scripts" menu items translated.

Diffs

plugins/example.py (d2ea5ed)
plugins/google_images.py (5317ba6)
plugins/wiktionary/wiktionary_sound.py (1e03b02)

View Diff

--===============4778454208660289703==-- --===============7026225397393920658== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============7026225397393920658==--