'Re: Review Request 111788: Remove <!DOCTYPE> from UI messages'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-edu-devel
Subject: Re: Review Request 111788: Remove <!DOCTYPE> from UI messages
From: "Commit Hook" <null () kde ! org>
Date: 2013-08-17 19:51:15
Message-ID: 20130817195115.31910.75130 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111788/
-----------------------------------------------------------

(Updated Aug. 17, 2013, 7:51 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Description
-------

Simplify their HTML otherwise as well. This makes them much more pleasant to \
translate.

For example replace with <big> and with .

Also in calculator.ui change one message to use the h1 tag because I couldn't find \
much difference in font size or weight when compared to .

Also change to <big>. There is a size difference, but I \
don't know if it's big enough to warrant using a different tag. Fixed font sizes are \
not good.

Sorry about the unrelated formatting changes Qt Designer made to some .ui files.

Diffs
-----

  src/calculator/calculator.ui 853f5b2 
  src/calculator/concCalculator.ui b3ad5b1 
  src/calculator/gasCalculator.ui 9e862d8 
  src/calculator/nuclearCalculator.ui d973ba0 
  src/calculator/settings_calc.ui 0c1e301 
  src/isotopetable/isotopedialog.ui 2fb02e6 

Diff: http://git.reviewboard.kde.org/r/111788/diff/

Testing
-------

Checked that they looked good in Qt Designer. For some also checked how they looked \
when running Kalzium.

File Attachments
----------------

Calculator window before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_calculator_before.png
 Calculator window after
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_calculator_after.png
 Isotope table before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_isotopetable_before.png
 Isotope table after
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_isotopetable_after.png

Thanks,

Lasse Liehu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111788/">http://git.reviewboard.kde.org/r/111788/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Lasse Liehu.</div>

<p style="color: grey;"><i>Updated Aug. 17, 2013, 7:51 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Simplify their HTML otherwise as well. This makes them much more \
pleasant to translate.

For example replace &lt;span style=&quot;font-size:12pt&quot;&gt; with &lt;big&gt; \
and &lt;span style=&quot;font-weight:600;&quot;&gt; with &lt;b&gt;.

Also in calculator.ui change one message to use the h1 tag because I couldn&#39;t \
find much difference in font size or weight when compared to &lt;span \
style=&quot;font-size:18pt; font-weight:600;&quot;&gt;.

Also change &lt;span style=&quot;font-size:14pt&quot;&gt; to &lt;big&gt;. There is a \
size difference, but I don&#39;t know if it&#39;s big enough to warrant using a \
different tag. Fixed font sizes are not good.

Sorry about the unrelated formatting changes Qt Designer made to some .ui \
files.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked that they looked good in Qt Designer. For some also checked how \
they looked when running Kalzium.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/calculator/calculator.ui <span style="color: grey">(853f5b2)</span></li>

 <li>src/calculator/concCalculator.ui <span style="color: grey">(b3ad5b1)</span></li>

 <li>src/calculator/gasCalculator.ui <span style="color: grey">(9e862d8)</span></li>

 <li>src/calculator/nuclearCalculator.ui <span style="color: \
grey">(d973ba0)</span></li>

 <li>src/calculator/settings_calc.ui <span style="color: grey">(0c1e301)</span></li>

 <li>src/isotopetable/isotopedialog.ui <span style="color: \
grey">(2fb02e6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111788/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_calculator_before.png">Calculator \
window before</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_calculator_after.png">Calculator \
window after</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_isotopetable_before.png">Isotope \
table before</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/kalzium_isotopetable_after.png">Isotope \
table after</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 