From kde-edu-devel Thu Aug 15 04:39:01 2013 From: "Commit Hook" Date: Thu, 15 Aug 2013 04:39:01 +0000 To: kde-edu-devel Subject: Re: Review Request 111470: Allow loading google images plugin on non-ASCII locales Message-Id: <20130815043901.5178.44952 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-edu-devel&m=137654157701418 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7175528847029823665==" --===============7175528847029823665== Content-Type: multipart/alternative; boundary="===============6687949115426116184==" --===============6687949115426116184== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111470/ ----------------------------------------------------------- (Updated Aug. 15, 2013, 4:38 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Edu and Frederik Gladhorn. Description ------- Parley Google images plugin fails to load in Ukrainian (Cyrillic) with the message: /usr/share/apps/parley/plugins/google_images.py, line 250: 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128) Backtrace: File "/usr/share/apps/parley/plugins/google_images.py", line 250, in action1.statusTip = str(i18n("Fetches an image for the selected translation")) This patch tries to avoid this inconvenience. Diffs ----- plugins/google_images.py 5317ba6 Diff: http://git.reviewboard.kde.org/r/111470/diff/ Testing ------- No errors while loading editor. Plugin does not work anyway, but it's a different story. ;) Thanks, Yuri Chornoivan --===============6687949115426116184== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111470/

This change has been marked as submitted.

Review request for KDE Edu and Frederik Gladhorn.

By Yuri Chornoivan.

Updated Aug. 15, 2013, 4:38 a.m.

Description

Parley Google images plugin fails to load in Ukrainian (Cyrillic) with the message:

/usr/share/apps/parley/plugins/google_images.py, line 250:
'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
Backtrace:
File "/usr/share/apps/parley/plugins/google_images.py", line 250, in <module>
action1.statusTip = str(i18n("Fetches an image for the selected translation"))

This patch tries to avoid this inconvenience.

Testing

No errors while loading editor. Plugin does not work anyway, but it's a different story. ;)

Diffs

plugins/google_images.py (5317ba6)

View Diff

--===============6687949115426116184==-- --===============7175528847029823665== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============7175528847029823665==--