--===============8219471420143304935== Content-Type: multipart/alternative; boundary="===============0478894851258795200==" --===============0478894851258795200== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110953/ ----------------------------------------------------------- (Updated Aug. 6, 2013, 4:26 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Edu and David Narváez. Description ------- Polish FindBoostPython.cmake from CMake's point of view: * Use BoostPython_ prefix instead of BOOST_PYTHON_ (BOOSTPYTHON_ is also acceptable but is unreadable); * Remove extra call to find_package(BoostPython); * Replace macro_optional_find_package() with simple find_package(), CMake has CMAKE_DISABLE_FIND_PACKAGE_Foo feature for a while. This is a first patch of a bigger set, containing only minor fixes. This addresses bug 320807. http://bugs.kde.org/show_bug.cgi?id=320807 Diffs ----- CMakeLists.txt 3c3da29 KigConfigureChecks.cmake fed38b3 cmake/modules/FindBoostPython.cmake d6c5a34 Diff: http://git.reviewboard.kde.org/r/110953/diff/ Testing ------- OpenBSD-CURRENT, CMake 2.8.11, KDE 4.10.4, Boost 1.53, Python 3.3 and 2.7. Thanks, Vadim Zhukov --===============0478894851258795200== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110953/

This change has been marked as submitted.

Review request for KDE Edu and David Narváez.

By Vadim Zhukov.

Updated Aug. 6, 2013, 4:26 p.m.

Description

Polish FindBoostPython.cmake from CMake's point of view:
  
 * Use BoostPython_ prefix instead of BOOST_PYTHON_
   (BOOSTPYTHON_ is also acceptable but is unreadable);

 * Remove extra call to find_package(BoostPython);

 * Replace macro_optional_find_package() with simple find_package(),
   CMake has CMAKE_DISABLE_FIND_PACKAGE_Foo feature for a while.

This is a first patch of a bigger set, containing only minor fixes.

Testing

OpenBSD-CURRENT, CMake 2.8.11, KDE 4.10.4, Boost 1.53, Python 3.3 and 2.7.

Bugs: 320807

Diffs

CMakeLists.txt (3c3da29)
KigConfigureChecks.cmake (fed38b3)
cmake/modules/FindBoostPython.cmake (d6c5a34)

View Diff

--===============0478894851258795200==-- --===============8219471420143304935== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============8219471420143304935==--