'Re: Review Request 111472: Used KIO for opening and saving a file in Khipu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 111472: Used KIO for opening and saving a file in Khipu
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2013-07-18 15:57:05
Message-ID: 20130718155705.22944.23297 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111472/#review36130
-----------------------------------------------------------

Ship it!

Ship It!

- Aleix Pol Gonzalez

On July 12, 2013, 4:12 p.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111472/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 4:12 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
> 
> 
> Description
> -------
> 
> Used KIO for saving and opening a file in khipu. I have already reviewed this diff \
> with Antonio. But still , I think it is better to publish it once ! 
> 
> Diffs
> -----
> 
> src/CMakeLists.txt 027da30 
> src/mainwindow.h 137e82c 
> src/mainwindow.cpp 67d8c72 
> 
> Diff: http://git.reviewboard.kde.org/r/111472/diff/
> 
> 
> Testing
> -------
> 
> done ! worked perfectly ! 
> 
> 
> Thanks,
> 
> Punit Mehta
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111472/">http://git.reviewboard.kde.org/r/111472/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aleix</p>

<br />
<p>On July 12th, 2013, 4:12 p.m. UTC, Punit Mehta wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño \
Aucahuasi.</div> <div>By Punit Mehta.</div>

<p style="color: grey;"><i>Updated July 12, 2013, 4:12 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used KIO for saving and opening a file in khipu. I have already reviewed \
this diff with Antonio. But still , I think it is better to publish it once !</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">done ! worked perfectly ! </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/CMakeLists.txt <span style="color: grey">(027da30)</span></li>

 <li>src/mainwindow.h <span style="color: grey">(137e82c)</span></li>

 <li>src/mainwindow.cpp <span style="color: grey">(67d8c72)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111472/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 