'Re: Review Request 110617: Implemented Open Action for Khipu'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 110617: Implemented Open Action for Khipu
From:       "Punit Mehta" <punit9461 () gmail ! com>
Date:       2013-06-17 13:12:05
Message-ID: 20130617131205.11332.77667 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110617/
-----------------------------------------------------------

(Updated June 17, 2013, 1:12 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño \
Aucahuasi.

Description
-------

The diff contains the implementation of the open action in Khipu.! The \
attached parent diff is for the save action which is already reviewed.!  If \
the user saves the plotspaces in .khipu file and then  he can open the file \
when he wants.! The initial implementation is done in a way that it \
considers the case only when on work is done ( i.e the user has just opened \
the application and then in the very next step , he is going to open his \
previously saved .khipu file.! I am working for dealing with the other \
cases also..! 

- I have added the entry of plot-colot in the .khipu file as we are \
requesting and creating the plots when the plotspace-thumbnail is \
doubleclicked.! So , we need that information also.!

Diffs
-----

  CMakeLists.txt f7dc583 
  src/CMakeLists.txt 0a50c54 
  src/dashboard.h a2a9c46 
  src/dashboard.cpp 688a49d 
  src/datastore.h a1276a7 
  src/datastore.cpp 616e0cc 
  src/mainwindow.h 1f059f8 
  src/mainwindow.cpp 9d6e010 
  src/plotseditor.h 47304c6 
  src/plotseditor.cpp 106cdf5 

Diff: http://git.reviewboard.kde.org/r/110617/diff/

Testing
-------

Done.! as mentioned , it works very well for the specified case.!

Thanks,

Punit Mehta

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110617/">http://git.reviewboard.kde.org/r/110617/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo \
Triveño Aucahuasi.</div> <div>By Punit Mehta.</div>

<p style="color: grey;"><i>Updated June 17, 2013, 1:12 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The diff contains the implementation of the open action in \
Khipu.! The attached parent diff is for the save action which is already \
reviewed.!  If the user saves the plotspaces in .khipu file and then  he \
can open the file when he wants.! The initial implementation is done in a \
way that it considers the case only when on work is done ( i.e the user has \
just opened the application and then in the very next step , he is going to \
open his previously saved .khipu file.! I am working for dealing with the \
other cases also..! 

- I have added the entry of plot-colot in the .khipu file as we are \
requesting and creating the plots when the plotspace-thumbnail is \
doubleclicked.! So , we need that information also.!</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done.! as mentioned , it works very well for the specified \
case.!</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(f7dc583)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(0a50c54)</span></li>

 <li>src/dashboard.h <span style="color: grey">(a2a9c46)</span></li>

 <li>src/dashboard.cpp <span style="color: grey">(688a49d)</span></li>

 <li>src/datastore.h <span style="color: grey">(a1276a7)</span></li>

 <li>src/datastore.cpp <span style="color: grey">(616e0cc)</span></li>

 <li>src/mainwindow.h <span style="color: grey">(1f059f8)</span></li>

 <li>src/mainwindow.cpp <span style="color: grey">(9d6e010)</span></li>

 <li>src/plotseditor.h <span style="color: grey">(47304c6)</span></li>

 <li>src/plotseditor.cpp <span style="color: grey">(106cdf5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110617/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 