'Re: Review Request 108806: kig: Use standard cmake module to find boost_python'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 108806: kig: Use standard cmake module to find boost_python
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-06-16 14:16:00
Message-ID: 20130616141600.13965.56926 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108806/
-----------------------------------------------------------

(Updated June 16, 2013, 2:15 p.m.)

Status
------

This change has been discarded.

Review request for KDE Edu.

Description
-------

With boost-1.50.0 and cmake-2.8.9 kig fails to build with following error message:
CMakeFiles/kigpart.dir/scripting/python_scripter.o:python_scripter.cc:function \
initkig: error: undefined reference to 'boost::python::detail::init_module(char \
                const*, void (*)())'
collect2: error: ld returned 1 exit status
make[2]: *** [lib/kigpart.so] Error 1

The attached diff fixes it for me.

Diffs
-----

  CMakeLists.txt aa4cc117f90ebe083d3fc5ff775e8b5e29b580db 
  cmake/COPYING-CMAKE-SCRIPTS 4b417765f3a834ce6b0a216f6b6c0fe2d3f0bed5 
  cmake/FindBoostPython.cmake 6d5f05edd58f0306dfa5a7ec08c1f7646427446e 
  cmake/modules/FindBoostPython.cmake 72aae5473c61f8ae68fe5d0f104d274a182072aa 

Diff: http://git.reviewboard.kde.org/r/108806/diff/

Testing
-------

Thanks,

Heiko Becker

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108806/">http://git.reviewboard.kde.org/r/108806/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Heiko Becker.</div>

<p style="color: grey;"><i>Updated June 16, 2013, 2:15 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With boost-1.50.0 and cmake-2.8.9 kig fails to build with following \
error message: CMakeFiles/kigpart.dir/scripting/python_scripter.o:python_scripter.cc:function \
initkig: error: undefined reference to &#39;boost::python::detail::init_module(char \
                const*, void (*)())&#39;
collect2: error: ld returned 1 exit status
make[2]: *** [lib/kigpart.so] Error 1

The attached diff fixes it for me.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(aa4cc117f90ebe083d3fc5ff775e8b5e29b580db)</span></li>

 <li>cmake/COPYING-CMAKE-SCRIPTS <span style="color: \
grey">(4b417765f3a834ce6b0a216f6b6c0fe2d3f0bed5)</span></li>

 <li>cmake/FindBoostPython.cmake <span style="color: \
grey">(6d5f05edd58f0306dfa5a7ec08c1f7646427446e)</span></li>

 <li>cmake/modules/FindBoostPython.cmake <span style="color: \
grey">(72aae5473c61f8ae68fe5d0f104d274a182072aa)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108806/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 