[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 110992: Changed some code in plotsdictionarymodel.cpp and
From: "Punit Mehta" <punit9461 () gmail ! com>
Date: 2013-06-14 17:13:34
Message-ID: 20130614171334.9617.56595 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110992/
-----------------------------------------------------------
(Updated June 14, 2013, 5:13 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
Description
-------
Improvement in the code of plotsdictionarymodel class in analitzaplot.
1) Initially , the constructor itself creates the dictionary. Now , the constructor \
just initializes the object and user/programmer can create the dictionary according \
to the wish and the flow of the program. 2) Also , I have added some improvements to \
support plotting from the dictionary for both the dimensions ( dim2D and dim3D ). For \
that , the assumption is that the dictionary file ( .plots file ) will contain the \
dimension in the first line as a comment ( e.g. [// dimension :=2 //] code in the \
first line in .plot file). 3) I have also added some other dictionary files ( for \
dim2D and dim3D ) so that other application based on Analitza ( in my case Khipu ) \
can use the dictionary support very well. These dictionary files are just for testing \
purpose. I am still looking forward in creating a rich collection of dictionary \
files. Here, the dictionary files will be installed in the directory whose path will \
be like : [ default-kde-path / libanalitza /plots ].
-> Once , the change will be merged in analitzaplot , khipu can also work very well \
as far as the dictionary support is concerned. :)
Diffs
-----
analitzaplot/data/plots/3Ds.plots PRE-CREATION
analitzaplot/data/plots/basic_curves.plots 42d8ec7
analitzaplot/data/plots/conics.plots PRE-CREATION
analitzaplot/data/plots/polar.plots PRE-CREATION
analitzaplot/plotsdictionarymodel.h a308cdc
analitzaplot/plotsdictionarymodel.cpp 3e99167
Diff: http://git.reviewboard.kde.org/r/110992/diff/
Testing
-------
Done.. works in khipu .. but I am not sure if other part of analitza uses \
plotsdictionarymodel. If that is the case , then we need to change the code for that \
class also . but as fas as I know , there is not any other class which depends on \
plotsdictionarymodel in analitza.
Thanks,
Punit Mehta
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110992/">http://git.reviewboard.kde.org/r/110992/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño \
Aucahuasi.</div> <div>By Punit Mehta.</div>
<p style="color: grey;"><i>Updated June 14, 2013, 5:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Improvement in the code of plotsdictionarymodel class in analitzaplot.
1) Initially , the constructor itself creates the dictionary. Now , the constructor \
just initializes the object and user/programmer can create the dictionary according \
to the wish and the flow of the program. 2) Also , I have added some improvements to \
support plotting from the dictionary for both the dimensions ( dim2D and dim3D ). For \
that , the assumption is that the dictionary file ( .plots file ) will contain the \
dimension in the first line as a comment ( e.g. [// dimension :=2 //] code in the \
first line in .plot file). 3) I have also added some other dictionary files ( for \
dim2D and dim3D ) so that other application based on Analitza ( in my case Khipu ) \
can use the dictionary support very well. These dictionary files are just for testing \
purpose. I am still looking forward in creating a rich collection of dictionary \
files. Here, the dictionary files will be installed in the directory whose path will \
be like : [ default-kde-path / libanalitza /plots ].
-> Once , the change will be merged in analitzaplot , khipu can also work very \
well as far as the dictionary support is concerned. :) </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done.. works in khipu .. but I am not sure if other part of analitza \
uses plotsdictionarymodel. If that is the case , then we need to change the code for \
that class also . but as fas as I know , there is not any other class which depends \
on plotsdictionarymodel in analitza.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>analitzaplot/data/plots/3Ds.plots <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>analitzaplot/data/plots/basic_curves.plots <span style="color: \
grey">(42d8ec7)</span></li>
<li>analitzaplot/data/plots/conics.plots <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>analitzaplot/data/plots/polar.plots <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>analitzaplot/plotsdictionarymodel.h <span style="color: \
grey">(a308cdc)</span></li>
<li>analitzaplot/plotsdictionarymodel.cpp <span style="color: \
grey">(3e99167)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110992/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic