'Re: Review Request 110712: Removed the space description entry from the khipu-specific file.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 110712: Removed the space description entry from the khipu-specific file.
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2013-05-29 20:29:53
Message-ID: 20130529202953.24130.94910 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110712/#review33377
-----------------------------------------------------------

Update the older review instead of creating a new one: \
https://git.reviewboard.kde.org/r/110414/

Will make easier the reviewing process...

- Aleix Pol Gonzalez

On May 29, 2013, 3:16 p.m., Punit Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110712/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 3:16 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño \
> Aucahuasi. 
> 
> Description
> -------
> 
> As discussed with Aliex , I have removed the code from the open and save \
> action that deals with the space-description. 
> If we want , then we can even add it in the future !
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt f7dc583 
> src/CMakeLists.txt 0a50c54 
> src/dashboard.h a2a9c46 
> src/dashboard.cpp 688a49d 
> src/datastore.h a1276a7 
> src/datastore.cpp 616e0cc 
> src/mainwindow.h 1f059f8 
> src/mainwindow.cpp 9d6e010 
> src/plotseditor.h 47304c6 
> src/plotseditor.cpp 106cdf5 
> 
> Diff: http://git.reviewboard.kde.org/r/110712/diff/
> 
> 
> Testing
> -------
> 
> done.
> 
> 
> Thanks,
> 
> Punit Mehta
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110712/">http://git.reviewboard.kde.org/r/110712/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Update the older review instead of creating a new one: \
https://git.reviewboard.kde.org/r/110414/

Will make easier the reviewing process...</pre>
 <br />

<p>- Aleix</p>

<br />
<p>On May 29th, 2013, 3:16 p.m. UTC, Punit Mehta wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo \
Triveño Aucahuasi.</div> <div>By Punit Mehta.</div>

<p style="color: grey;"><i>Updated May 29, 2013, 3:16 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed with Aliex , I have removed the code from the \
open and save action that deals with the space-description.

If we want , then we can even add it in the future !
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">done.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(f7dc583)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(0a50c54)</span></li>

 <li>src/dashboard.h <span style="color: grey">(a2a9c46)</span></li>

 <li>src/dashboard.cpp <span style="color: grey">(688a49d)</span></li>

 <li>src/datastore.h <span style="color: grey">(a1276a7)</span></li>

 <li>src/datastore.cpp <span style="color: grey">(616e0cc)</span></li>

 <li>src/mainwindow.h <span style="color: grey">(1f059f8)</span></li>

 <li>src/mainwindow.cpp <span style="color: grey">(9d6e010)</span></li>

 <li>src/plotseditor.h <span style="color: grey">(47304c6)</span></li>

 <li>src/plotseditor.cpp <span style="color: grey">(106cdf5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110712/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 