[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 110086: Solved the problem with the filter support using drop-down menu in Khipu
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2013-04-24 11:50:24
Message-ID: 20130424115024.16160.14680 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110086/#review31488
-----------------------------------------------------------
src/dashboard.cpp
<http://git.reviewboard.kde.org/r/110086/#comment23457>
Here you're not setting the parent widget, so please merge the 2 constructors.
- Aleix Pol Gonzalez
On April 19, 2013, 1:34 p.m., Punit Mehta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110086/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 1:34 p.m.)
>
>
> Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño Aucahuasi.
>
>
> Description
> -------
>
> Solved the issue of filter by dimension.. Now, plots can be easily differenciated \
> by using DimALL,Dim2D,Dim3D in the drop-down menu. I am working for the text edit \
> part , now...!
>
> Diffs
> -----
>
> src/dashboard.h a2a9c46
> src/dashboard.cpp 688a49d
> src/filter.h 80085f3
> src/filter.cpp 16b6b8e
> src/mainwindow.cpp 9d6e010
>
> Diff: http://git.reviewboard.kde.org/r/110086/diff/
>
>
> Testing
> -------
>
> Done..! Worked perfectly for the drop-down box.!
>
>
> Thanks,
>
> Punit Mehta
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110086/">http://git.reviewboard.kde.org/r/110086/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110086/diff/1/?file=139826#file139826line90" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/dashboard.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Dashboard::Dashboard(QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">90</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">Dashboard</span><span class="o">::</span><span \
class="n">Dashboard</span><span class="p">(</span><span \
class="n">Dashboard</span><span class="o">*</span> <span class="n">source</span><span \
class="p">){</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here \
you're not setting the parent widget, so please merge the 2 constructors.</pre> \
</div> <br />
<p>- Aleix</p>
<br />
<p>On April 19th, 2013, 1:34 p.m. UTC, Punit Mehta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu, Aleix Pol Gonzalez and Percy Camilo Triveño \
Aucahuasi.</div> <div>By Punit Mehta.</div>
<p style="color: grey;"><i>Updated April 19, 2013, 1:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Solved the issue of filter by dimension.. Now, plots can be easily \
differenciated by using DimALL,Dim2D,Dim3D in the drop-down menu. I am working for \
the text edit part , now...! </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Done..! Worked perfectly for the drop-down box.! </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/dashboard.h <span style="color: grey">(a2a9c46)</span></li>
<li>src/dashboard.cpp <span style="color: grey">(688a49d)</span></li>
<li>src/filter.h <span style="color: grey">(80085f3)</span></li>
<li>src/filter.cpp <span style="color: grey">(16b6b8e)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(9d6e010)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110086/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic