'Re: Review Request 107104: Adds support for SLC applet, making cantor Activity-Enabled.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 107104: Adds support for SLC applet, making cantor Activity-Enabled.
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-04-04 18:17:16
Message-ID: 20130404181716.7234.8039 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107104/#review30390
-----------------------------------------------------------

If noone reviews this I'll discard it in one month, seems noone is really interested in the feature.

- Albert Astals Cid

On Oct. 29, 2012, 11:24 a.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107104/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2012, 11:24 a.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Description
> -------
> 
> This small patch adds support for Share like Connect and the Activity infrastructure done by Ivan.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7d9d39e 
>   src/CMakeLists.txt c92dd99 
>   src/cantor.h b401a9c 
>   src/cantor.cpp 3278b59 
> 
> Diff: http://git.reviewboard.kde.org/r/107104/diff/
> 
> 
> Testing
> -------
> 
> compiled, not crashing.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107104/">http://git.reviewboard.kde.org/r/107104/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If noone reviews this \
I&#39;ll discard it in one month, seems noone is really interested in the \
feature.</pre>  <br />

<p>- Albert</p>

<br />
<p>On October 29th, 2012, 11:24 a.m. UTC, Tomaz  Canabrava wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Tomaz  Canabrava.</div>

<p style="color: grey;"><i>Updated Oct. 29, 2012, 11:24 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This small patch adds support for Share like Connect and the Activity \
infrastructure done by Ivan.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled, not crashing.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(7d9d39e)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(c92dd99)</span></li>

 <li>src/cantor.h <span style="color: grey">(b401a9c)</span></li>

 <li>src/cantor.cpp <span style="color: grey">(3278b59)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107104/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 