[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 108592: Added some more operations in analitza
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-04-02 22:05:51
Message-ID: 20130402220551.26113.61742 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 2, 2013, 3:38 p.m., Aleix Pol Gonzalez wrote:
> > Where did you get the lg command from? For the moment we're only implementing the \
> > operators suggested by MathML content markup [1]
> > Also you didn't clean up the imaginary numbers changes, please review it and make \
> > sure you know what you're trying to get in.
> > [1] http://www.w3.org/TR/MathML2/chapter4.html#contm.funopqual
>
> Heena Mahour wrote:
> I havenot yet updated the diff since I am getting some error \
> .Secondly,http://mathworld.wolfram.com/Lg.html okay,wont implement lg .
What error are you getting when trying to update the diff?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108592/#review26541
-----------------------------------------------------------
On Feb. 2, 2013, 2:31 p.m., Heena Mahour wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108592/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2013, 2:31 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Description
> -------
>
> I added a few logic gates operations like xnor,nor ,log function lg(base 2),and \
> complex functions -real,imaginary,conjugate,argument.
>
> Diffs
> -----
>
> analitza/operations.cpp 37b9820
> analitza/operator.h dd7a93e
> analitza/operator.cpp 4e5535b
> analitza/tests/analitzatest.cpp f41aaf1
>
> Diff: http://git.reviewboard.kde.org/r/108592/diff/
>
>
> Testing
> -------
>
> I am not sure about the complex functions rest seems fine I guess :p(Though \
> compiled successfully)
>
> File Attachments
> ----------------
>
> removed complex functions
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/analitza.patch
>
>
> Thanks,
>
> Heena Mahour
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108592/">http://git.reviewboard.kde.org/r/108592/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 2nd, 2013, 3:38 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Where did you get the lg command from? For the moment we're only \
implementing the operators suggested by MathML content markup [1]
Also you didn't clean up the imaginary numbers changes, please review it and make \
sure you know what you're trying to get in.
[1] http://www.w3.org/TR/MathML2/chapter4.html#contm.funopqual</pre>
</blockquote>
<p>On February 3rd, 2013, 4:28 a.m. UTC, <b>Heena Mahour</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I havenot yet updated \
the diff since I am getting some error .Secondly,http://mathworld.wolfram.com/Lg.html \
okay,wont implement lg . </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What error are you \
getting when trying to update the diff?</pre> <br />
<p>- Albert</p>
<br />
<p>On February 2nd, 2013, 2:31 p.m. UTC, Heena Mahour wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Heena Mahour.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2013, 2:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I added a few logic gates operations like xnor,nor ,log function lg(base \
2),and complex functions -real,imaginary,conjugate,argument.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I am not sure about the complex functions rest seems fine I guess \
:p(Though compiled successfully)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>analitza/operations.cpp <span style="color: grey">(37b9820)</span></li>
<li>analitza/operator.h <span style="color: grey">(dd7a93e)</span></li>
<li>analitza/operator.cpp <span style="color: grey">(4e5535b)</span></li>
<li>analitza/tests/analitzatest.cpp <span style="color: grey">(f41aaf1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108592/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/27/analitza.patch">removed \
complex functions </a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic