[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 109189: [Kig] Merge nowarnings Branch into master
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-02-28 23:10:08
Message-ID: 20130228231008.29147.1090 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109189/#review28309
-----------------------------------------------------------
filters/latexexporteroptions.cc
<http://git.reviewboard.kde.org/r/109189/#comment21129>
personally i don't like this, can you implement all the cases instead of adding a \
default? This way when there are new enums we will get a warning instead of being \
catched by the default:
misc/special_constructors.cc
<http://git.reviewboard.kde.org/r/109189/#comment21130>
personally i think that just commenting or removing the "os" parameter name is \
better, if you use Q_UNUSED if you start using "os" in the code later the Q_UNUSED \
will still be there and will look weird, if you comment or remove the param name \
you'll have to uncomment/add it so it will not be contradictory
- Albert Astals Cid
On Feb. 27, 2013, 11:11 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109189/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2013, 11:11 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Description
> -------
>
> I started the nowarnings branch with the goal of eliminating all compilation \
> branches in Kig. This will hopefully improve the perceived quality of the current \
> code and help developers spot warnings when submitting new code.
> This branch currently compiles without warnings in GCC 4.{6,7,8} and Clang 3.2. \
> While most changes deal with the -Woverloaded-virtual warning in GCC, some changes \
> are worth double checking: kig.cpp, main.cpp and calcpaths.cc.
>
> Diffs
> -----
>
> filters/asyexporter.cc cbb872f1c3873019d6ca686cf75c7d1613be6a7c
> filters/asyexporterimpvisitor.h 630d0915d5211f525f37a8f1f546509ec4c61aef
> filters/cabri-filter.cc 411b450355981447f3e901551897968899e03396
> filters/latexexporter.cc 9edd34cc88eaf14b479007c4e2e8a1994e9656db
> filters/latexexporteroptions.cc be127827215f8539eebd615c94d09eef643638bc
> filters/pgfexporterimpvisitor.h 165f2df8ad9866fd1e43ae4160b90abcf2e74281
> filters/xfigexporter.cc 4c26cbff3a8f27b7a07570cb146c59895942c3f3
> kig/kig.cpp af1b9fe775f0115947cb427d3e6d115f88d7507c
> kig/main.cpp 94277a308cd83737ba63f803c6852204b05dd0b5
> misc/calcpaths.cc 4facd8fb797607fc1e8dc0f13752c98c92a78e9b
> misc/special_constructors.cc 23325bdca937b6947d73ccd80ae957c8f3f24346
> modes/base_mode.h e1365c6ebea58e3e010f19ba0a1118eb79970a9b
> modes/construct_mode.h ba069069a7ce62859a2eed43a8d9c4a9e3e78807
> modes/macro.h 2d58141c1a3c04877c41343fe24d7b3d10a17618
> modes/normal.h 1e11e6f67227eb4d9232470d080877bd9e1ec0e3
> objects/conic_types.h 849871f19d13c9b30209d72b3bffc9409cc3d769
> objects/line_type.h 5a95552edeb0e73aa13138d7815ed871a65d1347
> scripting/python_scripter.cc 7b882bda1b071533407cd880b93586fb2fb2cb92
> scripting/script_mode.h 4cbfd73763bef44061fe5a09c6254d95fa884a95
>
> Diff: http://git.reviewboard.kde.org/r/109189/diff/
>
>
> Testing
> -------
>
> 1. Compiled and ran the application using GCC 4.6 (32 bits), GCC 4.{7,8} and Clang \
> in (64 bits). 2. Compiled and ran with the --convert-to-native option
>
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109189/">http://git.reviewboard.kde.org/r/109189/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109189/diff/1/?file=116088#file116088line53" \
style="color: black; font-weight: bold; text-decoration: \
underline;">filters/latexexporteroptions.cc</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
LatexExporterOptions::setFormat(LatexExporterOptions::LatexOutputFormat \
format)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nl">default:</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">personally \
i don't like this, can you implement all the cases instead of adding a default? \
This way when there are new enums we will get a warning instead of being catched by \
the default: </pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109189/diff/1/?file=116094#file116094line1590" \
style="color: black; font-weight: bold; text-decoration: \
underline;">misc/special_constructors.cc</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">GenericAffinityConstructor::GenericAffinityConstructor()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1590</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_UNUSED</span><span class="p">(</span><span class="n">os</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">personally \
i think that just commenting or removing the "os" parameter name is better, \
if you use Q_UNUSED if you start using "os" in the code later the Q_UNUSED \
will still be there and will look weird, if you comment or remove the param name \
you'll have to uncomment/add it so it will not be contradictory</pre> </div>
<br />
<p>- Albert</p>
<br />
<p>On February 27th, 2013, 11:11 a.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2013, 11:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I started the nowarnings branch with the goal of eliminating all \
compilation branches in Kig. This will hopefully improve the perceived quality of the \
current code and help developers spot warnings when submitting new code.
This branch currently compiles without warnings in GCC 4.{6,7,8} and Clang 3.2. While \
most changes deal with the -Woverloaded-virtual warning in GCC, some changes are \
worth double checking: kig.cpp, main.cpp and calcpaths.cc.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Compiled and ran the application using GCC 4.6 (32 bits), GCC 4.{7,8} \
and Clang in (64 bits). 2. Compiled and ran with the --convert-to-native option</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/asyexporter.cc <span style="color: \
grey">(cbb872f1c3873019d6ca686cf75c7d1613be6a7c)</span></li>
<li>filters/asyexporterimpvisitor.h <span style="color: \
grey">(630d0915d5211f525f37a8f1f546509ec4c61aef)</span></li>
<li>filters/cabri-filter.cc <span style="color: \
grey">(411b450355981447f3e901551897968899e03396)</span></li>
<li>filters/latexexporter.cc <span style="color: \
grey">(9edd34cc88eaf14b479007c4e2e8a1994e9656db)</span></li>
<li>filters/latexexporteroptions.cc <span style="color: \
grey">(be127827215f8539eebd615c94d09eef643638bc)</span></li>
<li>filters/pgfexporterimpvisitor.h <span style="color: \
grey">(165f2df8ad9866fd1e43ae4160b90abcf2e74281)</span></li>
<li>filters/xfigexporter.cc <span style="color: \
grey">(4c26cbff3a8f27b7a07570cb146c59895942c3f3)</span></li>
<li>kig/kig.cpp <span style="color: \
grey">(af1b9fe775f0115947cb427d3e6d115f88d7507c)</span></li>
<li>kig/main.cpp <span style="color: \
grey">(94277a308cd83737ba63f803c6852204b05dd0b5)</span></li>
<li>misc/calcpaths.cc <span style="color: \
grey">(4facd8fb797607fc1e8dc0f13752c98c92a78e9b)</span></li>
<li>misc/special_constructors.cc <span style="color: \
grey">(23325bdca937b6947d73ccd80ae957c8f3f24346)</span></li>
<li>modes/base_mode.h <span style="color: \
grey">(e1365c6ebea58e3e010f19ba0a1118eb79970a9b)</span></li>
<li>modes/construct_mode.h <span style="color: \
grey">(ba069069a7ce62859a2eed43a8d9c4a9e3e78807)</span></li>
<li>modes/macro.h <span style="color: \
grey">(2d58141c1a3c04877c41343fe24d7b3d10a17618)</span></li>
<li>modes/normal.h <span style="color: \
grey">(1e11e6f67227eb4d9232470d080877bd9e1ec0e3)</span></li>
<li>objects/conic_types.h <span style="color: \
grey">(849871f19d13c9b30209d72b3bffc9409cc3d769)</span></li>
<li>objects/line_type.h <span style="color: \
grey">(5a95552edeb0e73aa13138d7815ed871a65d1347)</span></li>
<li>scripting/python_scripter.cc <span style="color: \
grey">(7b882bda1b071533407cd880b93586fb2fb2cb92)</span></li>
<li>scripting/script_mode.h <span style="color: \
grey">(4cbfd73763bef44061fe5a09c6254d95fa884a95)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109189/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic