'Re: Review Request 109001: Avoid using std::string where possible'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 109001: Avoid using std::string where possible
From:       "Andreas Cord-Landwehr" <cola () uni-paderborn ! de>
Date:       2013-02-19 15:40:21
Message-ID: 20130219154021.16170.66034 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109001/#review27728
-----------------------------------------------------------

Ship it!

Thanks for the patch (and the explenation!), just tested that still all unit tests pass.

- Andreas Cord-Landwehr

On Feb. 17, 2013, 11:10 p.m., Thiago Macieira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109001/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2013, 11:10 p.m.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Description
> -------
> 
> QString::toStdString() is more expensive than QString::toLatin1()
> since it must go through the "codec for C strings" codec and it must
> use std::string. Without C++11, it has no move semantics.
> 
> 
> Diffs
> -----
> 
>   RocsCore/Data.cpp c0c3fe8 
>   RocsCore/DataStructure.cpp 6277081 
>   RocsCore/DataStructures/LinkedList/ListStructure.cpp f510d66 
>   RocsCore/LoadSave/Plugins/gmlFileFormat/CMakeLists.txt 651f89b 
>   RocsCore/Modifiers/ValueModifier.cpp 90e26bb 
>   RocsCore/Pointer.cpp f1f171f 
>   VisualEditor/Scene/DataItem.cpp 8be7700 
>   VisualEditor/Scene/PointerItem.cpp 8efe0ec 
> 
> Diff: http://git.reviewboard.kde.org/r/109001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thiago Macieira
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109001/">http://git.reviewboard.kde.org/r/109001/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch \
(and the explenation!), just tested that still all unit tests pass.</pre>  <br />

<p>- Andreas</p>

<br />
<p>On February 17th, 2013, 11:10 p.m. UTC, Thiago Macieira wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Thiago Macieira.</div>

<p style="color: grey;"><i>Updated Feb. 17, 2013, 11:10 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QString::toStdString() is more expensive than QString::toLatin1() since \
it must go through the &quot;codec for C strings&quot; codec and it must use \
std::string. Without C++11, it has no move semantics. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>RocsCore/Data.cpp <span style="color: grey">(c0c3fe8)</span></li>

 <li>RocsCore/DataStructure.cpp <span style="color: grey">(6277081)</span></li>

 <li>RocsCore/DataStructures/LinkedList/ListStructure.cpp <span style="color: \
grey">(f510d66)</span></li>

 <li>RocsCore/LoadSave/Plugins/gmlFileFormat/CMakeLists.txt <span style="color: \
grey">(651f89b)</span></li>

 <li>RocsCore/Modifiers/ValueModifier.cpp <span style="color: \
grey">(90e26bb)</span></li>

 <li>RocsCore/Pointer.cpp <span style="color: grey">(f1f171f)</span></li>

 <li>VisualEditor/Scene/DataItem.cpp <span style="color: grey">(8be7700)</span></li>

 <li>VisualEditor/Scene/PointerItem.cpp <span style="color: \
grey">(8efe0ec)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109001/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 