'Review Request 108917: Let GenericAffinityTransform and GenericProjectivityTransform use Repeated Po'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request 108917: Let GenericAffinityTransform and GenericProjectivityTransform use Repeated Po
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2013-02-12 7:55:55
Message-ID: 20130212075555.31443.69762 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108917/
-----------------------------------------------------------

Review request for KDE Edu and Christoph Feck.

Description
-------

This change is pretty trivial, but I'd like some BIC experts to check if I can commit \
this to 4.10. This is a year-old bug that was quite trivial to solve and I just \
realized that, so I wouldn't want users to wait for another major release for a fix.

Diffs
-----

  misc/object_constructor.h fbd019c 
  misc/special_constructors.h d60d3d7 
  misc/special_constructors.cc 94f7d50 

Diff: http://git.reviewboard.kde.org/r/108917/diff/

Testing
-------

1. Create 4 points
2. Create a line
3. Create a generic affinity transform that uses 3 of the 4 points as source vertex \
and 2 of the 3 source vertex plus the 4th point as the 3 destination vertex

Before this patch, you would end up having 6 points.

Thanks,

David Narváez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108917/">http://git.reviewboard.kde.org/r/108917/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Christoph Feck.</div>
<div>By David Narváez.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This change is pretty trivial, but I&#39;d like some BIC experts to \
check if I can commit this to 4.10. This is a year-old bug that was quite trivial to \
solve and I just realized that, so I wouldn&#39;t want users to wait for another \
major release for a fix.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Create 4 points 2. Create a line
3. Create a generic affinity transform that uses 3 of the 4 points as source vertex \
and 2 of the 3 source vertex plus the 4th point as the 3 destination vertex

Before this patch, you would end up having 6 points.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>misc/object_constructor.h <span style="color: grey">(fbd019c)</span></li>

 <li>misc/special_constructors.h <span style="color: grey">(d60d3d7)</span></li>

 <li>misc/special_constructors.cc <span style="color: grey">(94f7d50)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108917/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 