'Re: Review Request 104138: Request to review this patch submit which fixes the bug #152182'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 104138: Request to review this patch submit which fixes the bug #152182
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-02-08 22:57:34
Message-ID: 20130208225734.11689.50596 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104138/#review27028
-----------------------------------------------------------

This does not fix the bug at all.

* Start kmplot
* Create a cartesian plot
* Tick the enable sliders checkbox in the parameters
* Go to the View menu, see how the "Show sliders" is marked but you are not seeing the sliders window

- Albert Astals Cid

On March 1, 2012, 10:23 p.m., Rahul Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104138/
> -----------------------------------------------------------
> 
> (Updated March 1, 2012, 10:23 p.m.)
> 
> 
> Review request for KDE Edu, Klaus-Dieter Möller and Burkhard Lück.
> 
> 
> Description
> -------
> 
> Attached two .diff files (patches) which fixes the bug.
> 
> 
> This addresses bug 152182.
>     http://bugs.kde.org/show_bug.cgi?id=152182
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/104138/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2012/03/01/ksliderwindow.diff
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2012/03/01/ksliderwindow_h.diff
> 
> 
> Thanks,
> 
> Rahul Sharma
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104138/">http://git.reviewboard.kde.org/r/104138/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This does not fix the \
bug at all.

* Start kmplot
* Create a cartesian plot
* Tick the enable sliders checkbox in the parameters
* Go to the View menu, see how the &quot;Show sliders&quot; is marked but you are not \
seeing the sliders window</pre>  <br />

<p>- Albert</p>

<br />
<p>On March 1st, 2012, 10:23 p.m. UTC, Rahul Sharma wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu, Klaus-Dieter Möller and Burkhard Lück.</div>
<div>By Rahul Sharma.</div>

<p style="color: grey;"><i>Updated March 1, 2012, 10:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attached two .diff files (patches) which fixes the bug.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=152182">152182</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104138/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2012/03/01/ksliderwindow.diff">ksliderwindow.diff</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2012/03/01/ksliderwindow_h.diff">ksliderwindow_h.diff</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 